1134240 - pasting filtered urls in irc/etc. fails due to spaces

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

while investigating talos failures, it is common to communicate in bugs, irc, email with links to treeherder to show a filtered view.  Here is an example:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&fromchange=2aee204e65cb&tochange=23c78316747f&filter-searchStr=Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound talos svgr

The problem is the filter has spaces in it and the clickable url is broken which means the filter doesn't apply.

Comment 1

[Jonathan French (:jfrench)]

Maybe just a newbie thing on my part, but I wonder from a product standpoint why Chrome just handles it correctly and inserts the %20 for the user, where Firefox does not. eg. bug 633386.

Comment 2

[Jonathan French (:jfrench)]

Make that bug 633836.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

tbpl works just fine, so this is something specific to treeherder:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=Windows%207%2032-bit%20mozilla-inbound%20talos%20xperf

that doesn't mean that chrome handles it better than Firefox, it probably means that tbpl has hacked around this.

Comment 4

[Jonathan French (:jfrench)]

Yup, I was just talking in general terms, per that open bug.

Comment 5

[Jonathan French (:jfrench)]

Thinking filterVal here could receive a similar tbpl-esque tweak
https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/js/controllers/filters.js#L228

Comment 6

[Jonathan French (:jfrench)]

I spent a while on this today. encodeURIComponent() works as expected, but I am not groking the correct way to isolate that modified search from the model (which also populates the UI input). If I can get it sorted I'll assign myself.

Comment 7

[Phil Ringnalda (:philor)]

What tbpl did wasn't a hack, it did the right thing, and put params after the ? and before the # where they belong, unlike treeherder which causes multiple sorts of pain by making the entire URL a hash. Nevertheless one of us really should have realized that this was new Firefox bustage.

Comment 8

[Ed Morley [:emorley]]

This was fixed by two things:
- Bug 1148861 was backed out, which broke Nightly.
- Bug 1152414 encoded the link, so if you use "copy link location" in Chrome, it works there too