1134250 - Change everything.me endpoint for all 1.1/1.3/1.3T/1.4 branches

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Peter Dolanjski [:pdol]]

Currently, 1.3/1.3T/1.4 branches point directly to an Everything.me endpoint.  As we transition their services over to Mozilla, changing that endpoint for 1.3/1.3T/1.4 branches to a Mozilla controlled one would mean we can avoid relying on a traffic redirection solution from Everything.me in the future.

The endpoint should be updated to appsearch.services.mozilla.com.

Until Mozilla hosts the new service, the server will actually redirect to api.everything.me.  

NOTE: Before this is landed, it needs to be tested to make sure the endpoint redirection is working like expected.

Comment 1

[Peter Dolanjski [:pdol]]

1.1 should also be done as well in case it is needed in the future.

Comment 2

[Peter Dolanjski [:pdol]]

Gregor, could you assign this to someone?  We will be asking partners to apply this patch for all devices that haven't launched and we'll likely also see if we can get others to do an OTA update to apply this patch.

Comment 3

[Gregor Wagner [:gwagner]]

The devices team maintains these branches. Keven, can your team take care of this?

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Pull request - Update v1.4 appsearch endpoint

I can go ahead and take this.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8568124 [details] [review]
Pull request - Update v1.4 appsearch endpoint

Ran or Cristian - would either of you have the time for a quick review here? Thanks!

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8568124 [details] [review]
Pull request - Update v1.4 appsearch endpoint

LGTM, thanks a lot

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 8568124 [details] [review]
Pull request - Update v1.4 appsearch endpoint

Tested on 1.4 device, works well

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8568124 [details] [review]
Pull request - Update v1.4 appsearch endpoint

Bhavana - I actually want to request approval for 1.1 here I think, but not sure how to do that, so just requesting for 1.3. Who should grant this request?

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Updating everything.me endpoint to a Mozilla controlled URL.
[User impact] if declined: It gives us more control over the endpoint and possibly a slightly better performing redirect in the future.
[Testing completed]: Manual testing.
[Risk to taking this patch] (and alternatives if risky): Low risk, just updating a URL.
[String changes made]: None.

Comment 9

[Keven Kuo [:kkuo]]

(In reply to Kevin Grandon :kgrandon from comment #4)
> Created attachment 8568124 [details] [review]
> Pull request - Update v1.4 appsearch endpoint
> 
> I can go ahead and take this.

Hi! Kevin,

Thanks.

--
Keven

Comment 10

[bhavana bajaj [:bajaj]]

(In reply to Kevin Grandon :kgrandon from comment #8)
> Comment on attachment 8568124 [details] [review]
> Pull request - Update v1.4 appsearch endpoint
> 
> Bhavana - I actually want to request approval for 1.1 here I think, but not
> sure how to do that, so just requesting for 1.3. Who should grant this
> request?
> 
> NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to
> better understand the B2G approval process and landings.
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #): Updating everything.me endpoint
> to a Mozilla controlled URL.
> [User impact] if declined: It gives us more control over the endpoint and
> possibly a slightly better performing redirect in the future.
> [Testing completed]: Manual testing.
> [Risk to taking this patch] (and alternatives if risky): Low risk, just
> updating a URL.
> [String changes made]: None.

Firstly, sorry for the late response here.

Given we are no longer maintaining those older releases, is it still worth getting this in ? Given this is client side unless people are going to pick this new build, how is this going to help ?

Comment 11

[Kevin Grandon :kgrandon]

(In reply to bhavana bajaj [:bajaj] from comment #10)
> Given we are no longer maintaining those older releases, is it still worth
> getting this in ? Given this is client side unless people are going to pick
> this new build, how is this going to help ?

Redirecting the needinfo to Peter. I assume this is only needed if we are going to be doing a release or OTA update of these older branches.

Comment 12

[Peter Dolanjski [:pdol]]

Kevin is right.  There is an offline discussion with the details, but this is needed in the event that partners are going to do OTA updates.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v1.4:     https://github.com/mozilla-b2g/gaia/commit/6081fcd91f8eabd61fe4a306945627966c2c27ce
v1.3:     https://github.com/mozilla-b2g/gaia/commit/f947e45bbf8a71ad72c1d5f6d53fdc99221d866d
v1.2:     https://github.com/mozilla-b2g/gaia/commit/912874175ce206a9ad76fe25f94c4d5f2e1eb589
v1-train: https://github.com/mozilla-b2g/gaia/commit/468eef32ab7c51b2c8ebf0d6fd3cbd083050cf68

Additionally, v1.3 was merged to v1.3t and v1-train was merged to v1.1.0hd. Good times.