Closed Bug 1134363 Opened 9 years ago Closed 2 years ago

Tab title changes while reader view is loading

Categories

(Toolkit :: Reader Mode, defect, P5)

Product:
Toolkit
Component:
Reader Mode
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: Margaret, Assigned: kabakert)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reader-mode-firefox-integration])

Attachments

(2 files)

WIP: Bug 1134363 - Fixed the tab title setting incorrectly when placing a breakpoint in _setTabLabel. r=niklas,mtigley
48 bytes, text/x-phabricator-request
Details | Review
Bug 1134363 - Have Reader Mode use the same tab title as the normal browser view. r=niklas,mtigley
48 bytes, text/x-phabricator-request
Details | Review 
Similar to bug 1123910, but for the tab title.
Unfocused and/or jaws: could this be a mentor bug?
Flags: needinfo?(jaws)
Flags: needinfo?(bmcbride)
Yeah, I think Matt can take this as his next bug :)

It can take the same route that we do for other about: pages I think, not sure why that isn't working.
Assignee: nobody → hammerly.matt
Mentor: jaws
Flags: needinfo?(jaws)
Flags: needinfo?(bmcbride)
We have code that explicitly sets the title of the about: page to be the same as the title of the article:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/reader/AboutReader.jsm?force=1#582

This makes sense if you're loading the article directly from the list, but if you're loading it by clicking on the reader toolbar button, it would be nice if we could short-circuit this and just keep the title the same.
Bug 1017156 was what I was thinking of in comment #2, but that was for new tabs that were opened. Since readermode uses the same tab, it's going to be a different codepath.
Hm, looking deeper in to this bug it might be tougher than I thought. At least, I'm not sure yet where this change needs to be made. Re-adding the needinfo for Blair.
Assignee: hammerly.matt → nobody
Mentor: jaws
Flags: needinfo?(bmcbride)
Sorry, I'm already far too swamped with ReaderList - I don't have enough time for all the reviews coming in, let alone mentoring :(
Flags: needinfo?(bmcbride)
Priority: -- → P4
Whiteboard: [reader-ui]
Priority: P4 → P5
Whiteboard: [reader-ui] → [reader-mode-firefox-integration]
Assignee: nobody → kabakert
Status: NEW → ASSIGNED
Attachment #9269761 - Attachment description: Bug 1134363 - Fixed tab title setting incorrectly when entering Reader Mode. r=niklas,mtigley → Bug 1134363 - Prevented the about:reader URL from temporarily displaying, changed Reader Mode to use the same tab title as the normal browser view. r=niklas,mtigley
Attachment #9269761 - Attachment description: Bug 1134363 - Prevented the about:reader URL from temporarily displaying, changed Reader Mode to use the same tab title as the normal browser view. r=niklas,mtigley → Bug 1134363 - Tab Title Fixed: Prevented about:reader URL from temporarily displaying, fixed Reader Mode to use the same tab title as the normal browser view. r=niklas,mtigley
Attachment #9269761 - Attachment description: Bug 1134363 - Tab Title Fixed: Prevented about:reader URL from temporarily displaying, fixed Reader Mode to use the same tab title as the normal browser view. r=niklas,mtigley → Bug 1134363 - Tab Title Fixes: Prevented about:reader URL from temporarily displaying, fixed Reader Mode to use the same tab title as the normal browser view. r=niklas,mtigley
Attachment #9269761 - Attachment description: Bug 1134363 - Tab Title Fixes: Prevented about:reader URL from temporarily displaying, fixed Reader Mode to use the same tab title as the normal browser view. r=niklas,mtigley → Bug 1134363 - Have Reader Mode use the same tab title as the normal browser view. r=niklas,mtigley
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/54705ece88ec
Have Reader Mode use the same tab title as the normal browser view. r=niklas,mtigley

https://hg.mozilla.org/mozilla-central/rev/54705ece88ec

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: