1134424 - [e10s] "Save Image/Audio/Video As..." in remote browser causes unsafe CPOW usage warning

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Ian Moody [:Kwan] (UTC+0)]

+++ This bug was initially created as a clone of Bug #1133577 +++

STR:

1) Visit a site with some images, <audio/>s, <video/>s, or <canvas/>s on it in an e10s window
2) Right-click on one of the media elements, and choose "Save Image/Audio/Video As..."

This causes some "unsafe CPOW usage" warnings in the Browser Console.

In browser/base/content/nsContextMenu.js:

  saveHelper: function(linkURL, linkText, dialogTitle, bypassCache, doc) {
[...]
    if (channel instanceof Ci.nsIHttpChannel) {
      channel.referrer = BrowserUtils.makeURIFromCPOW(doc.documentURIObject); <-- Causes CPOW warning [audio, video]
      if (channel instanceof Ci.nsIHttpChannelInternal)
        channel.forceAllowThirdPartyCookie = true;
    }

[...]

  // Save URL of the clicked upon image, video, or audio.
  saveMedia: function() {
    var doc =  this.target.ownerDocument; <-- Causes CPOW warning
    if (this.onCanvas) {
      // Bypass cache, since it's a data: URL.
      saveImageURL(this.target.toDataURL(), "canvas.png", "SaveImageTitle", <-- Causes CPOW warning [canvas]
                   true, false, BrowserUtils.makeURIFromCPOW(doc.documentURIObject), doc); <-- Causes CPOW warning [canvas]
    }
    else if (this.onImage) {
      urlSecurityCheck(this.mediaURL, this.principal);
      saveImageURL(this.mediaURL, null, "SaveImageTitle", false,
                   false, BrowserUtils.makeURIFromCPOW(doc.documentURIObject), doc); <-- Causes CPOW warning [image]
    }
    else if (this.onVideo || this.onAudio) {
      urlSecurityCheck(this.mediaURL, this.principal);
      var dialogTitle = this.onVideo ? "SaveVideoTitle" : "SaveAudioTitle";
      this.saveHelper(this.mediaURL, null, dialogTitle, false, doc);
    }
  },


in toolkit/modules/BrowserUtils.jsm

  makeURIFromCPOW: function(aCPOWURI) {
    return Services.io.newURI(aCPOWURI.spec, aCPOWURI.originCharset, null); <-- Causes CPOW warning
  },

warnings are tagged e.g. [image] if they only occur with certain element types.

Comment 1

[Ian Moody [:Kwan] (UTC+0)]

Attachment: MozReview Request: bz://1134424/Kwan

/r/6985 - Bug 1134424 - Use message to safely get the dataURL of the canvas for saving
/r/7359 - Bug 1134424 - Use the existing reference to the document in nsContextMenu.saveMedia() rather than unsafely creating a new one

Pull down these commits:

hg pull -r 7ca6efe0e6d13e86e885dab531ccae97624e079c https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8596041 [details]
MozReview Request: bz://1134424/Kwan

https://reviewboard.mozilla.org/r/6983/#review6251

Ship It!

Comment 3

[Ian Moody [:Kwan] (UTC+0)]

Green try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=be1f9ab374bf

Comment 4

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/9c5fc44bda0b
https://hg.mozilla.org/integration/fx-team/rev/5863c2d9f9ae

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9c5fc44bda0b
https://hg.mozilla.org/mozilla-central/rev/5863c2d9f9ae

Comment 7

[Ian Moody [:Kwan] (UTC+0)]

Attachment: MozReview Request: Bug 1134424 - Use message to safely get the dataURL of the canvas for saving

Comment 8

[Ian Moody [:Kwan] (UTC+0)]

Attachment: MozReview Request: Bug 1134424 - Use the existing reference to the document in nsContextMenu.saveMedia() rather than unsafely creating a new one