Closed Bug 1134428 Opened 5 years ago Closed 5 years ago

js/src/make-source-package.sh is out of date

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: jimb, Assigned: jimb)

References

Details

Attachments

(1 file)

The js/src/make-source-package.sh script, which is supposed to build a stand-alone SpiderMonkey distribution, is out of date. The tar file produced no longer includes all the files necessary to build SpiderMonkey.
Attachment #8566256 - Flags: review?(sphink)
Attachment #8566256 - Flags: review?(sphink) → review?(sstangl)
Comment on attachment 8566256 [details] [diff] [review]
Update js/src/make-source-package.sh to include all source files now needed for a SpiderMonkey build.

Review of attachment 8566256 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/make-source-package.sh
@@ +30,5 @@
>  	;;
>  "build")
> +        # Ensure that the configure script is newer than the configure.in script.
> +        if [ ${SRCDIR}/configure.in -nt ${SRCDIR}/configure ]; then
> +            echo "error: js/src/configure is out of date. Please regenerate before packaging." >&2

This is nice. Thanks!
Attachment #8566256 - Flags: review?(sstangl) → review+
Blocks: 1134039
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a3a3cb8522d
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.