Closed Bug 1134480 Opened 9 years ago Closed 9 years ago

Show sections in history list

Categories

(Firefox for iOS :: Home screen, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: wesj, Unassigned)

References

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
We should show headers in history for today/yesterday/etc.
Blocks: 1130494
Attached file Pull request
This styles the dividers we have to match the mockups better (still needs tweaking) and adds them in history. The glass effect shows some of its "optimizations" here (i.e. you can see it do some strange things). Lets see what UX thinks.
Attachment #8568031 - Flags: review?(bnicholson)
Comment on attachment 8568031 [details] [review]
Pull request

Looks OK with cleanup. I know the PR for the first two commits landed, but I'm not sure about the third (Create a Join table for bookmark favicons). I guess this needs to wait for that commit since this depends on JoinedHistoryVisitsTable.swift?
Attachment #8568031 - Flags: review?(bnicholson) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Landed a second follow up PR as well:
https://github.com/mozilla/firefox-ios/pull/184
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: