1134520 - Autophone - fails to detect proper app name for non-nightly try builds

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

If you submit a try build to autophone, it will determine the package name at:

https://github.com/mozilla/autophone/blob/master/builds.py#L791

It will adjust the package name if the build is an official build but otherwise will leave the package name alone.

If the build is a beta build on try, it will be incorrectly identified as org.mozilla.fennec. When Autophone attempts to install the build, it will uninstall org.mozilla.fennec and install org.mozilla.firefox_beta. The next attempt to install a firefox_beta build will also attempt to uninstall org.mozilla.fennec and the fail when installing org.mozilla.firefox_beta since the previous build wasn't correctly uninstalled.

We should either adjust the calculated package name or better yet use the actual package name in package-name.txt contained in the build.apk.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1134520-autophone-v1.patch

This patch is for autophone and adds:

detection of app name using package-name.txt,
detection of build type from build_url,
fall back for missing SourceRepository,
add mozilla-release to supported list of repos,
sorts the repo names for clarity.

The missing SourceRepository which has caused problems with developer builds was actually fixed in bug 1057600, but this will work around the issue until the patch is merged.

I tested this with mozilla-central, mozilla-inbound, mozilla-beta, mozilla-aurora, mozilla-release.

There is an additional problem with running a mixture of these repos in the event that a test run fails to clean up after itself and leaves a previous build such as mozilla-beta installed. If we then try to run a mozilla-inbound build, Android will prompt whether to use Beta or Nightly to run the webappstartup webapp. I will handle that in a separate bug.

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: bug-1134520-phonedash-v1.patch

The appname for beta is really org.mozilla.firefox_beta and the appname for firefox is org.mozilla.firefox.

Comment 3

[Mark Côté [:mcote]]

Comment on attachment 8566951 [details] [diff] [review]
bug-1134520-autophone-v1.patch

Review of attachment 8566951 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: builds.py
@@ +792,5 @@
> +            repo = cfg.get('App', 'SourceRepository')
> +        except ConfigParser.NoOptionError:
> +            logger.warning('%s does not specifiy SourceRepository. '
> +                           'Guessing mozilla-central.' % build_url)
> +            repo = 'https://hg.mozilla.org/mozilla-central/'

I'm curious as to the utility of defaulting to mozilla-central.  If there's a good reason to do this, there should be a comment.

Comment 4

[Bob Clary [:bc] (inactive)]

(In reply to Mark Côté [:mcote] from comment #3)

> I'm curious as to the utility of defaulting to mozilla-central.  If there's
> a good reason to do this, there should be a comment.

Not a really good reason.

Now that bug 1057600 is fixed, this will no longer be an issue for new builds on the nightly branches (mozilla-central, mozilla-inbound, etc) and will not be an issue for the beta, aurora or release branches after the trains complete.

I thought of perhaps using mozilla-inbound since many developers would *probably* be using that to submit patches, but in reality they could have been on fx-team though probably not b2g-inbound. Without any good reason to pick one over another, I went with the final 'shipping' target of the merges which is mozilla-central. For at least some of the revisions, the same revision id will appear in both mozilla-inbound and mozilla-central.

Comment 5

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/1ec6798d9df5a0412cc42ae8abf2161d7c38cf10

Comment 6

[Bob Clary [:bc] (inactive)]

https://github.com/markrcote/phonedash/commit/7bd6a8c1f57737a21b2cb06103d81d1078e77083