1134579 - IRC commands broken in nightly from Feb 19th 2015

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

STR:
1) Try to use any IRC command
OR
2) Try to tab complete a command in an IRC conversation

Nothing happens, and the error console shows:
> Timestamp: 2/19/15, 4:51:32 PM
> Error: NS_NOINTERFACE: Component does not have requested interface [imICommand.usageContext]
> Source File: resource://gre/components/imCommands.js
> Line: 175

Comment 1

[aleth [:aleth]]

Adding 
command.__proto__ = ClassInfo("imICommand", "Chat command");
to jsProtoHelper::registerCommands fixes this.

Comment 2

[aleth [:aleth]]

Attachment: commandinterface.diff

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8566563 [details] [diff] [review]
commandinterface.diff

Review of attachment 8566563 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for debugging this! :-)

::: chat/modules/jsProtoHelper.jsm
@@ +817,5 @@
>      if (!this.commands)
>        return;
>  
>      this.commands.forEach(function(command) {
> +      command.QueryInterface = XPCOMUtils.generateQI([Ci.imICommand]);

This would override an existing implementation, which could be different if the object implemented more than one interface.

Comment 4

[aleth [:aleth]]

Attachment: commandinterface.diff v2

OK, but I didn't use hasOwnProperty as if it *is* already implemented, it's likely in the prototype chain.

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 8566637 [details] [diff] [review]
commandinterface.diff v2

Review of attachment 8566637 [details] [diff] [review]:
-----------------------------------------------------------------

Florian is curious how hard it would be to add a test...any idea?

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/fc563e49b1a2

Comment 7

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #5)
> Florian is curious how hard it would be to add a test...any idea?

imCommands already has decent tests, the problem is that it didn't catch this as that test doesn't go through XPConnect.

A test that could catch things like this would have to set up a conversation with some prpl and then check if it can find commands, without using loadSubScript. Maybe we can think of a good way to do something like this...