Closed Bug 1134599 Opened 9 years ago Closed 9 years ago

Fix Rpi build target in B2G

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: janjongboom, Assigned: janjongboom)

Details

Attachments

(1 file, 1 obsolete file)

0002-Bug-1134599-Fix-rpi-build-target.patch
3.84 KB, patch
shawnjohnjr
: review+
Details | Diff | Splinter Review 
It currently fails on some unreachable functions / declared but not used failures in SKIA related code and bluetooth
r? for gfx part
Assignee: nobody → janjongboom
Attachment #8566486 - Flags: review?(jacob.benoit.1)
Comment on attachment 8566486 [details] [diff] [review]
0001-Bug-1134599-Fix-rpi-build-target.patch

r? for bluetooth part
Attachment #8566486 - Flags: review?(shuang)
Comment on attachment 8566486 [details] [diff] [review]
0001-Bug-1134599-Fix-rpi-build-target.patch

Review of attachment 8566486 [details] [diff] [review]:
-----------------------------------------------------------------

I'm no longer working at Mozilla, sorry.
Attachment #8566486 - Flags: review?(jacob.benoit.1)
Attachment #8566486 - Flags: review?(jmuizelaar)
Attachment #8566486 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8566486 [details] [diff] [review]
0001-Bug-1134599-Fix-rpi-build-target.patch

Review of attachment 8566486 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/AudioManager.cpp
@@ +90,1 @@
>  static bool sA2dpSwitchDone = true;

What about the place (ProcessDelayedA2dpRoute) actually used variable sA2dpSwitchDone? If flag MOZ_B2G_BT is not defined, it could lead build break.
See:
https://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/AudioManager.cpp?from=dom/system/gonk/AudioManager.cpp#221
Attachment #8566486 - Flags: review?(shuang) → review-
Hmm, seems my patch was not complete. No clue what happened. Anyway, it's referenced from ProcessDelayedA2dpRoute which itself is only called from within a MOZ_B2G_BT block, and thus should also be under an #ifdef.

        Attachment #8566486 -
        Attachment is obsolete: true

        Attachment #8569094 -
        Flags: review?(shuang)

    
    

    
  
Comment on attachment 8569094 [details] [diff] [review]
0002-Bug-1134599-Fix-rpi-build-target.patch

r=me for file AudioManager.cpp only.

        Attachment #8569094 -
        Flags: review?(shuang) → review+
Flags: needinfo?(janjongboom)

    
    

    
  
checkin-needed, unless one of the sheriff's suspect that Linux Debug J failure is my fault (other tests pass after re-triggering the ones that intermittented first).
Flags: needinfo?(janjongboom)
Keywords: checkin-needed

    
    

    
  
hi jan, i retriggered this j failures lets see if they stay orange

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/67812860b997
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox39:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: