Closed
Bug 1134599
Opened 10 years ago
Closed 10 years ago
Fix Rpi build target in B2G
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: janjongboom, Assigned: janjongboom)
Details
Attachments
(1 file, 1 obsolete file)
|
3.84 KB,
patch
|
shawnjohnjr
:
review+
|
Details | Diff | Splinter Review |
It currently fails on some unreachable functions / declared but not used failures in SKIA related code and bluetooth
|
Assignee | |
Comment 1•10 years ago
|
||
r? for gfx part
Assignee: nobody → janjongboom
Attachment #8566486 -
Flags: review?(jacob.benoit.1)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8566486 [details] [diff] [review]
0001-Bug-1134599-Fix-rpi-build-target.patch
r? for bluetooth part
Attachment #8566486 -
Flags: review?(shuang)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8566486 [details] [diff] [review]
0001-Bug-1134599-Fix-rpi-build-target.patch
Review of attachment 8566486 [details] [diff] [review]:
-----------------------------------------------------------------
I'm no longer working at Mozilla, sorry.
Attachment #8566486 -
Flags: review?(jacob.benoit.1)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8566486 -
Flags: review?(jmuizelaar)
|
||
Updated•10 years ago
|
Attachment #8566486 -
Flags: review?(jmuizelaar) → review+
Comment on attachment 8566486 [details] [diff] [review]
0001-Bug-1134599-Fix-rpi-build-target.patch
Review of attachment 8566486 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/system/gonk/AudioManager.cpp
@@ +90,1 @@
> static bool sA2dpSwitchDone = true;
What about the place (ProcessDelayedA2dpRoute) actually used variable sA2dpSwitchDone? If flag MOZ_B2G_BT is not defined, it could lead build break.
See:
https://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/AudioManager.cpp?from=dom/system/gonk/AudioManager.cpp#221
Attachment #8566486 -
Flags: review?(shuang) → review-
|
|
Assignee | |
Comment 5•10 years ago
|
||
Hmm, seems my patch was not complete. No clue what happened. Anyway, it's referenced from ProcessDelayedA2dpRoute which itself is only called from within a MOZ_B2G_BT block, and thus should also be under an #ifdef.
|
|
Assignee | |
Comment 6•10 years ago
|
||
Attachment #8566486 -
Attachment is obsolete: true
Attachment #8569094 -
Flags: review?(shuang)
Comment on attachment 8569094 [details] [diff] [review]
0002-Bug-1134599-Fix-rpi-build-target.patch
r=me for file AudioManager.cpp only.
Attachment #8569094 -
Flags: review?(shuang) → review+
|
|
Assignee | |
Comment 8•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Flags: needinfo?(janjongboom)
|
|
Assignee | |
Comment 9•10 years ago
|
||
checkin-needed, unless one of the sheriff's suspect that Linux Debug J failure is my fault (other tests pass after re-triggering the ones that intermittented first).
Flags: needinfo?(janjongboom)
Keywords: checkin-needed
|
||
Comment 10•10 years ago
|
||
hi jan, i retriggered this j failures lets see if they stay orange
|
||
Comment 11•10 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 12•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•