Closed Bug 1134631 Opened 9 years ago Closed 8 years ago

Use the gaia_confirm shared element instead of the plethora of custom overlays we currently use

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: gsvelto, Unassigned)

References

Details

The dialer app uses a variety of different overlay/dialog implementations to display various messages, these include:

- The non-element confirm dialog available under shared/ (shared/js/confirm.js, shared/css/confirm.css)

- The custom dialog available under shared/ (shared/js/custom_dialog.js)

- The "loading-overlay" node (https://github.com/mozilla-b2g/gaia/blob/fb0f486244b68fd63c5dee993c1811f41e787a74/apps/communications/dialer/index.html#L284) which is implemented ad hoc in apps/communications/dialer/js/mmi_ui.js and uses the styles in shared/style/animations.css

We should replace all of them via the gaia_confirm shared element, possibly improving it to support a progress bar as currently used by the MMI code.
As a side note, possibly due to the CSS shared classes sometimes when showing/hiding a dialog you can catch a glimpse of another one. I've seen it happen only a few times and it's visible only for a fraction of a second so it's impossible to tell which one is it.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.