Closed Bug 1134702 Opened 9 years ago Closed 9 years ago

TelemetryPing doesn't need to listen to app-startup and content-child-shutdown

Categories

(Toolkit :: Telemetry, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: gfritzsche, Unassigned)

References

(Blocks 1 open bug)

Details

With breaking out things into TelemetrySession.jsm, TelemetryPing.jsm should only be used in the chrome process.
So:
* use a lazyModuleGetter for TelemetryPing.jsm in TelemetryStartup.js
* don't notify TelemetryPing of "app-startup" in TelemetryStartup.js
* remove "app-startup" and "content-child-shutdown" usage from TelemetryPing.observe
Blocks: 1122482
No longer blocks: 1134269
Blocks: 1120356
No longer blocks: 1122482
Blocks: 1122482
No longer blocks: 1120356
I think this bug needs to be changed or resolved due to the changes in bug 1137252.

- TelemetryPing needs to use "app-startup" to initialize Telemetry.canRecord* in the content (it was done in TelemetrySession but bug 1137252 moved that to TelemetryPing, so that all the initialization happens in one place).
- TelemetryPing no longer uses content-child-shutdown (it was really just using that to call |Preferences.ignore(PREF_BRANCH_LOG, configureLogging);|, which was moved to TelemetryPing shutdown).
This is obsoleted by the recent refactorings and other work.
Blocks: 1201022
No longer blocks: 1122482
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.