1134740 - Make vendor packages be used in preference to those globally installed

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Ed Morley [:emorley]]

Currently we:
sys.path.append(path('..', 'vendor'))

Rather than:
sys.path.insert(1, path('..', 'vendor'))

The site-packages version will be seen first - and unfortunately we have old versions of things like datasource in there, which is causing bug 1134140.

Comment 1

[Ed Morley [:emorley]]

Attachment: Use vendor packages in preference to globally installed

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/c59ff78589679138e2698c9c0ccfcdfcb81ec427
Bug 1134740 - Use vendor packages in preference to globally installed

There is currently duplication between the packages in vendor/ and those
globally installed on stage/production. This change ensures we use those
in vendor/ in preference to those in site-packages & so are using the
version we expected.

Comment 3

[Ed Morley [:emorley]]

Confirmation this has worked - compare the paths for datasource in these stack traces before/after:

Traceback (most recent call last):
...
File "/usr/lib/python2.7/site-packages/datasource/bases/SQLHub.py", line 245, in disconnect if self.connection[host_type]['con_obj'].open:
AttributeError: 'NoneType' object has no attribute 'open'

Traceback (most recent call last):
...
File "/data/www/treeherder.allizom.org/treeherder-service/treeherder/../vendor/datasource/bases/SQLHub.py", line 245, in disconnect if self.connection[host_type]['con_obj'].open:
AttributeError: 'NoneType' object has no attribute 'open'