1134744 - checkboxes and radiobuttons have a bad baseline if writingMode.IsLineInverted() applies

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: testcase for radiobutton/checkbox baselines

When text-orientation:sideways-right is in effect, checkboxes and radiobuttons in vertical-lr writing mode (where the line is "inverted" relative to block direction) get a bad baseline. See testcase, where the two examples should look the same, but the controls in the second block are offset to the left, pushing the lines apart.

(The problem doesn't show up with text-orientation:mixed or upright, but that's only because we default to a centered vertical baseline in this case.)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Fix baseline for form controls when line is inverted relative to block dir

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Reftest for baseline of radio button and checkbox

Here's a reftest that I think will work for this; waiting to see how it fares on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=49bbdf787060.

Comment 3

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d530c6ab9f11
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a03863c7384

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d530c6ab9f11
https://hg.mozilla.org/mozilla-central/rev/2a03863c7384