Closed Bug 1134744 Opened 5 years ago Closed 5 years ago

checkboxes and radiobuttons have a bad baseline if writingMode.IsLineInverted() applies

Categories

(Core :: Layout: Form Controls, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

Details

Attachments

(3 files)

When text-orientation:sideways-right is in effect, checkboxes and radiobuttons in vertical-lr writing mode (where the line is "inverted" relative to block direction) get a bad baseline. See testcase, where the two examples should look the same, but the controls in the second block are offset to the left, pushing the lines apart.

(The problem doesn't show up with text-orientation:mixed or upright, but that's only because we default to a centered vertical baseline in this case.)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Here's a reftest that I think will work for this; waiting to see how it fares on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=49bbdf787060.
Attachment #8567016 - Flags: review?(smontagu)
Attachment #8566653 - Flags: review?(smontagu) → review+
Attachment #8567016 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/mozilla-central/rev/d530c6ab9f11
https://hg.mozilla.org/mozilla-central/rev/2a03863c7384
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.