1134754 - Only compact zones where we can reclaim a useful amount of memory

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jon Coppeard (:jonco)]

At the moment we compact all zones that we collect in a shrinking GC.  However this is wasteful, because we may not be able to free much or any memory at all.

We should skip compacting zones if we cannot free up a certain proportion of their allocated memory.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: skip-unnecessary-compaction

This patch calculates the number of arenas that we are going to free up for each zone before deciding whether to compact or skip that zone.  The decision is based on the GC reason so that OOM or memory pressure GCs will free up all possible memory.  Otherwise we only compact if we can free at least 2% of the zone's GC heap memory (I made this number up so tuning may be required).

Comment 2

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55afade66202

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/55afade66202