1134819 - Firefox crash in VideoToolbox@0x3f24ad

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-4a384728-52ec-465b-b834-e42342150219.
=============================================================

Seen while running through Mac crash stats. Reproducible crash on latest beta/Aurora/Nightly. Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:36.0) Gecko/20100101 Firefox/36.0

STR:
1. Load http://readingeggspress.com/#!/comprehension_gym
2. crash

Comment 1

[Jean-Yves Avenard [:jya]]

Who runs 10.6 these days !??

Comment 2

[Jean-Yves Avenard [:jya]]

Works for me here... The MP4 itself is incorrectly formed, and contains out of order frames.
Is it crashing only on 10.6 or other OS X version ?

Detecting such type of videos and avoid calling VideoToolbox is likely impossible.
Interestingly, it seems that VDA bailed on it and refused to play, yet VideoToolBox simply crashes

Comment 3

[Marcia Knous [:marcia]]

I cannot reproduce the crash on my 10.10.3 machine, but the video shows as Green using Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:37.0) Gecko/20100101 Firefox/37.0 while it plays fine using Chrome and Safari. I can file a separate bug to track that.

Comment 4

[Marcia Knous [:marcia]]

(In reply to Jean-Yves Avenard [:jya] from comment #1)
> Who runs 10.6 these days !??

Apparently some, since they are crashing :) - so far I have only seen the crash on 10.6.

I updated Comment 3 to describe the behavior I see on my MPB 10.10 machine.

Comment 5

[Ralph Giles (:rillian)]

Plays ok on my 10.8.5 machine.

Comment 6

[Marcia Knous [:marcia]]

https://crash-stats.mozilla.com/report/list?signature=VideoToolbox%400x3f24ad&

There are some other URLs crashing on various versions of Firefox, but all the crashes are on 10.6.8

9 	http://www.squaretrade.com/
4 	http://www.zappos.com/camper-right-nina-21595-dark-gray
3 	http://www.zappos.com/onitsuka-tiger-by-asics-ultimate-81
3 	http://readingeggspress.com.au/
3 	http://www.zappos.com/blue-by-betsey-johnson-gown-silver-metallic
3 	http://www.streetdrugs.org/
3 	http://www.zappos.com/birkenstock-yara-oiled-leather-habana-oiled-leather

Comment 7

[Hubert Figuiere [:hub]]

(In reply to Jean-Yves Avenard [:jya] from comment #1)
> Who runs 10.6 these days !??

My GF still does since she doesn't want to upgrade. She got a similar crash tonight hence me locating that bug.

Don't know what URL / page caused it.

crash id is 7fb7eaac-da6e-49e7-95fb-d5ea72150909

Comment 8

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

We could disabling hardware decoding on VT to see if that helps. That may be throwing the baby out with the bath water.

Comment 9

[Jean-Yves Avenard [:jya]]

With 10.6 the default is to use VDA or VT (without HW as this is only supported from 10.9 onward)

Comment 10

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Would setting the dormant timeout to 0 reduce the number of crashes? This would mean we do a better job of using HW decoders rather than software ones.

Comment 11

[Jean-Yves Avenard [:jya]]

the crash is in VideoToolbox decoding thread. At a guess bug 1192675 is going to help the situation as we could have accessed the Video toolbox in a non thread-safe manner.

Using YUV420 will also help (in 41).

Increasing the use of HW ones may not help as VDA can't do some resolutions anyway ; with YouTube typically any videos < 360p can't be decoded in HW, VDA returns an error when attempting to create the decoder.

Comment 12

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

This bug hasn't been seen since 38.