Closed
Bug 1134831
Opened 9 years ago
Closed 9 years ago
Add ability to localize "License information" string in addons manager
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: spohl, Assigned: spohl)
References
Details
Attachments
(1 file, 1 obsolete file)
5.43 KB,
patch
|
spohl
:
review+
lmandel
:
approval-mozilla-aurora-
|
Details | Diff | Splinter Review |
Since we're uplifting Adobe EME to FF 37 we should get all strings in as soon as possible.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8566776 -
Flags: review?(gfritzsche)
Comment 2•9 years ago
|
||
Comment on attachment 8566776 [details] [diff] [review] Patch Review of attachment 8566776 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/mozapps/extensions/internal/GMPProvider.jsm @@ +62,5 @@ > { > id: "gmp-eme-adobe", > name: "eme-adobe_name", > description: "eme-adobe_description", > + licenseURL: "", Let's just make this null... @@ +555,5 @@ > let plugin = { > id: aPlugin.id, > name: pluginsBundle.GetStringFromName(aPlugin.name), > description: pluginsBundle.GetStringFromName(aPlugin.description), > + fullDescription: this.generateFullDescription(aPlugin, licenseInfo); ... and only add fullDescription if not null (or make it "" if required).
Attachment #8566776 -
Flags: review?(gfritzsche) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Thanks, Georg! Addressed feedback. Carrying over r+.
Attachment #8566776 -
Attachment is obsolete: true
Attachment #8566796 -
Flags: review+
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8566796 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: Adobe EME [User impact if declined]: The text "License information" in the addons manager will not be localizable. [Describe test coverage new/current, TreeHerder]: This is a fairly small and well-understood change and local testing shows that everything is still working as expected. [Risks and why]: None that I can think of. [String/UUID change made/needed]: This adds the string "License information" to the list of strings that can be localized.
Attachment #8566796 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbfe4013530a
Comment 6•9 years ago
|
||
Comment on attachment 8566796 [details] [diff] [review] Patch EME work is English only in 37. No need to uplift this one. Aurora-
Attachment #8566796 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
https://hg.mozilla.org/mozilla-central/rev/dbfe4013530a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•