Add ability to localize "License information" string in addons manager

RESOLVED FIXED in Firefox 38

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: spohl, Assigned: spohl)

Tracking

unspecified
mozilla38
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Since we're uplifting Adobe EME to FF 37 we should get all strings in as soon as possible.
(Assignee)

Comment 1

3 years ago
Created attachment 8566776 [details] [diff] [review]
Patch
Attachment #8566776 - Flags: review?(gfritzsche)
Comment on attachment 8566776 [details] [diff] [review]
Patch

Review of attachment 8566776 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/internal/GMPProvider.jsm
@@ +62,5 @@
>    {
>      id:              "gmp-eme-adobe",
>      name:            "eme-adobe_name",
>      description:     "eme-adobe_description",
> +    licenseURL:      "",

Let's just make this null...

@@ +555,5 @@
>          let plugin = {
>            id: aPlugin.id,
>            name: pluginsBundle.GetStringFromName(aPlugin.name),
>            description: pluginsBundle.GetStringFromName(aPlugin.description),
> +          fullDescription: this.generateFullDescription(aPlugin, licenseInfo);

... and only add fullDescription if not null (or make it "" if required).
Attachment #8566776 - Flags: review?(gfritzsche) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8566796 [details] [diff] [review]
Patch

Thanks, Georg! Addressed feedback. Carrying over r+.
Attachment #8566776 - Attachment is obsolete: true
Attachment #8566796 - Flags: review+
(Assignee)

Comment 4

3 years ago
Comment on attachment 8566796 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: Adobe EME
[User impact if declined]: The text "License information" in the addons manager will not be localizable.
[Describe test coverage new/current, TreeHerder]: This is a fairly small and well-understood change and local testing shows that everything is still working as expected.
[Risks and why]: None that I can think of.
[String/UUID change made/needed]: This adds the string "License information" to the list of strings that can be localized.
Attachment #8566796 - Flags: approval-mozilla-aurora?
Comment on attachment 8566796 [details] [diff] [review]
Patch

EME work is English only in 37. No need to uplift this one. Aurora-
Attachment #8566796 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
https://hg.mozilla.org/mozilla-central/rev/dbfe4013530a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.