1134833 - [RTL][Contacts] Contents on Duplicate Contacts screen are mirrored, but hit detection areas are not

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: logcat on Flame 3.0

Contents on 'Merge duplicates' screen are mirrored in RTL, but the hit box areas are not, which would confuse the user of proper interactions on this screen.

Prerequisite:
DUT is in RTL environment.

STR:
1) Create contact A
2) Create another contact that matches A's credentials
3) On the suggested merge contacts screen, tap the checkbox to the right of the name, and tap the left edge to the name.

Expected: Tapping on the checkbox would check/uncheck the checkbox, and tapping on the left edge of name would display details on what's causing duplicate suggestion. Hitbox area corresponds with UI.

Actual: Tapping on the checkbox displays details on duplicate suggestion, and tapping on the left edge of name checks/unchecks the checkbox. Hitbox area does not correspond with UI.

Repro rate: 10/10

Video of issue:
https://www.youtube.com/watch?v=aRr-Byffa-A

Attaching a logcat.

Device: Flame (KK, 319MB, full flash)
BuildID: 20150219010228
Gaia: 620aecfde85a8b093247837c55de2708e22be1e1
Gecko: 360b5f211180
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Comment 1

[Pi Wei Cheng [:piwei] (inactive)]

This issue also occurs on Flame 2.2. Merge contacts screen's hit detection area contradicts with UI.

Device: Flame 2.2
BuildID: 20150219002504
Gaia: ce79d35b92261e7cbfeaefebf87859ebeb0979b4
Gecko: 159a3907b959
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Adding the RTL Contacts Meta because I think it was removed unintentionally.

Nominating 2.2? since this could confuse and frustrate the end user.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Triage: RTL is a committed feature on 2.2. Shipping with this bug could confuse Arabic users.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] arcturus:bug-1134833 > mozilla-b2g:master

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8571294 [details] [review]
[gaia] arcturus:bug-1134833 > mozilla-b2g:master

Changing r? to Fernando, since Sergi seems to be busy

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8571294 [details] [review]
[gaia] arcturus:bug-1134833 > mozilla-b2g:master

LGTM

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/55c868aada08355602a586634a2051dc600d922a

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8571294 [details] [review]
[gaia] arcturus:bug-1134833 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
RTL
[User impact] if declined:
Bad user experience
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
Low
[String changes made]:
None

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/33f3fd3a0f4c769aa29cb7cfe3834e21f956ae51

Comment 10

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed in the lates Nightly Flame 3.0 and 2.2 builds.

Actual Results: The hit detection on the duplicate contacts screen in RTL languages matches the icons on the screen.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150311110236
Gaia: 2b87ee8e7e2ec30a9851b6b59a899006a98767ab
Gecko: bc6aeea72290
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150311002522
Gaia: 3f032238a52f08e4c2f68a47ad065a96eb22d470
Gecko: 004fa1cb1dd4
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0