security/sandbox/chromium/base/third_party/superfasthash/ contains a BSD license not in about:license

RESOLVED FIXED in Firefox 38

Status

()

Core
Security: Process Sandboxing
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bobowen, Assigned: bobowen)

Tracking

unspecified
mozilla39
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox38 fixed, firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
superfasthash was needed for the latest chromium sandbox code update in bug 1102195.

The licence for this needs adding to about:license.
(Assignee)

Comment 1

3 years ago
Created attachment 8567093 [details] [diff] [review]
Add license for SuperFastHash to about:license.

Thanks for the info in bug 1102195 comment 19.

This adds the text from the LICENSE file in that directory.

This is slightly different from the text at the top of the superfasthash.c file, which does not contain the "Paul Hsieh OLD BSD license" line at the start and breaks on different lines.

However the one I've included is the one included in Chrome's credits.

I used the text "This license applies to files in the directory" instead of "some files", as I think it is reasonable to assume that Chromium will only include files relating to SuperFastHash in this directory.
Attachment #8567093 - Flags: review?(gerv)
Comment on attachment 8567093 [details] [diff] [review]
Add license for SuperFastHash to about:license.

Review of attachment 8567093 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/license.html
@@ +4151,5 @@
> +      <span class="path">security/sandbox/chromium/base/third_party/superfasthash/</span>.</p>
> +
> +<pre>
> +Paul Hsieh OLD BSD license
> +

Please remove these two lines. With that, r=gerv.
Attachment #8567093 - Flags: review?(gerv) → review+
(Assignee)

Comment 3

3 years ago
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/24cf8a18a1a3

I was waiting until it looked like I wasn't going to have to do something for bug 1102195, due to the gcc-4.6 issue.

(In reply to Gervase Markham [:gerv] from comment #2)

> > +<pre>
> > +Paul Hsieh OLD BSD license
> > +
> 
> Please remove these two lines. With that, r=gerv.

Removed before landing, thanks.
Blocks: 1021233
(Assignee)

Comment 4

3 years ago
Comment on attachment 8567093 [details] [diff] [review]
Add license for SuperFastHash to about:license.

Approval Request Comment
[Feature/regressing bug #]:
This code was introduced by the patch for bug 1102195, but I didn't include the license.

[User impact if declined]:
None, but the license will be missing from our page.

[Describe test coverage new/current, TreeHerder]:
N/A

[Risks and why]: 
Low, just a change to our about:license page.

[String/UUID change made/needed]:
None
Attachment #8567093 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/24cf8a18a1a3
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Comment on attachment 8567093 [details] [diff] [review]
Add license for SuperFastHash to about:license.

No risk, taking.
Attachment #8567093 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.