1135063 - The "Select logs to delete" button can be used on the Call info page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Pre-requisites
Have a couple of logs in the call log.

STR
1. Go to call log information page

Expected results
Like in 2.1, this button shouldn't be showed

Actual results
This button is there and if you use it, you actually can't pick any log event but you can tap "Select All" and delete your entire call log!

Comment 1

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Regression which can lead to unwanted data loss.

QA wanted to check 2.2 and shoot a video (either on master or 2.2). If it does repro on 2.2, please nominate this bug to a 2.2 blocker.

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: logcat on Flame 2.2

This issue occurs on Flame 2.2. Long tapping on a call log, select Call Information, and the next page shows a checkmark button to the right of phone number that does not belong there and user is able to delete all call logs underneath the page.

Video of issue:
https://www.youtube.com/watch?v=bazF40q82Ww

Also attaching a logcat.

Device: Flame 2.2 (KK, shallow flash, 319MB mem)
BuildID: 20150220073201
Gaia: 2b694a5a332495f1b9db06253690a2f5a702ed80
Gecko: 5c20fbeb5f8b
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 3

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: See comment 1 + regression from 2.1

Comment 4

[Johan Lorenzo [:jlorenzo]]

Triage: Broken functionality. The fix might not worth a regression window.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1135063-hide-call-log-edit-button-in-call-info-view > mozilla-b2g:master

Comment 6

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8577287 [details] [review]
[gaia] gabrielesvelto:bug-1135063-hide-call-log-edit-button-in-call-info-view > mozilla-b2g:master

Crude solution to fix the problem. Ideally we'd want to show the call information panel as a slide-in element but to do so would require a significant refactoring. In the future I'd like to take a page from the SMS app on this topic with their navigation abstraction.

Comment 7

[Tamara Hills [:thills]]

Comment on attachment 8577287 [details] [review]
[gaia] gabrielesvelto:bug-1135063-hide-call-log-edit-button-in-call-info-view > mozilla-b2g:master

Hi Gabriele,

Looks good.  Do we need any follow up bug for the refactor that you were mentioning or is there already a bug for this in our backlog?  I don't remember seeing one, but the enhancement that you mention sounds nice.

Thanks,

-tamara

Comment 8

[Gabriele Svelto [:gsvelto]]

(In reply to Tamara Hills [:thills] from comment #7)
> Looks good.  Do we need any follow up bug for the refactor that you were
> mentioning or is there already a bug for this in our backlog?  I don't
> remember seeing one, but the enhancement that you mention sounds nice.

We don't have one yet but I'll file one. Thanks for the review!

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/737b2ee98eace678a8f78c1e563241bef8725f25

Comment 10

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8577287 [details] [review]
[gaia] gabrielesvelto:bug-1135063-hide-call-log-edit-button-in-call-info-view > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): -
[User impact] if declined: One can activate the call log deletion UI from the call info page. It's not a dramatic issue but it's a pretty ugly UI glitch.
[Testing completed]: Tested on a device
[Risk to taking this patch] (and alternatives if risky): Low risk since the changes are small, the alternative would be not to take the patch at all and live with the issue.
[String changes made]: None

Comment 12

[Shally Li（leave from Mozilla）]

Per Comment 9,this bug is fixed on Flame v3.0.

And this bug has been successfully verified on latest Flame v3.0.
See attachment: verified_v3.0.png
Reproduce rate: 0/5

STR:
Pre-requisite: Have a couple of logs in the "Call log".
1. Open Phone app and go to Call log tab.
2. Long tap on a call log, select "Call Information",look at the top right corner.
**The "Select logs to delete" button doesn't show in "Call Information" screen as expected.

Flame 3.0 build(Pass):
Build ID               20150317073344
Gaia Revision          738987bd80b0ddb4ccf853855388c2627e19dcc1
Gaia Date              2015-03-17 02:27:51
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/008b3f65a7e0
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150317.111450
Firmware Date          Tue Mar 17 11:15:00 EDT 2015
Bootloader             L1TC000118D0
-------------------------------------------------------------------------

Leaving "verifyme" for Flame v2.2.

Comment 13

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.png

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/5c6855ebf37f915398e714fba65427323f262b52

Comment 15

[Shally Li（leave from Mozilla）]

This bug has been successfully verified on latest Flame v2.2.
See attachment: verified_v2.2.png
Reproduce rate: 0/5


Flame 2.2 (Pass):
Build ID               20150322002503
Gaia Revision          44c62060581fde8de1e12e94cf55e9673b401a47
Gaia Date              2015-03-20 19:05:17
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e6140a32902a
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150322.043216
Firmware Date          Sun Mar 22 04:32:27 EDT 2015
Bootloader             L1TC000118D0

Comment 16

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2.png