1135102 - Split testDoorHanger in smaller test cases

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Robin Ricard [:rricard]]

As seen in bug 1085609, testDoorHanger may be too large to run efficiently on Android 2.3. We should split it in smaller test cases.

For example: it currently fails intermittently at line 171 (https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/testDoorHanger.java#171).

Comment 1

[:Margaret Leibovic]

Thanks for filing. Bug 1085609 popped up after I landed extra test logic in bug 1083879, so that may have pushed it over the edge.

I would start by just splitting that popup blocking test into its own test.

Comment 2

[Robin Ricard [:rricard]]

Ok, I'll look into it then ! Thanks for the directions !

Comment 3

[Robin Ricard [:rricard]]

Attachment: Split testDoorHanger in smaller test cases

Create a new test

Comment 4

[Robin Ricard [:rricard]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0103b8dcec4

Comment 5

[Robin Ricard [:rricard]]

Attachment: Split testDoorHanger in smaller test cases

Create a new test

Comment 6

[Robin Ricard [:rricard]]

Try: Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6d0c010f801

Comment 7

[:Margaret Leibovic]

Comment on attachment 8568043 [details] [diff] [review]
Split testDoorHanger in smaller test cases

Review of attachment 8568043 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Let's get a try run, and let's = also try re-enabling testDoorHanger on 2.3 devices, since this will hopefully address that intermittent issue.

Comment 8

[Robin Ricard [:rricard]]

Ok :) This just need a small rebase for me locally.

Comment 9

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.