Closed Bug 1135102 Opened 7 years ago Closed 1 year ago

Split testDoorHanger in smaller test cases

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: rricard, Assigned: rricard)

References

Details

Attachments

(1 file, 1 obsolete file)

As seen in bug 1085609, testDoorHanger may be too large to run efficiently on Android 2.3. We should split it in smaller test cases.

For example: it currently fails intermittently at line 171 (https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/testDoorHanger.java#171).
Thanks for filing. Bug 1085609 popped up after I landed extra test logic in bug 1083879, so that may have pushed it over the edge.

I would start by just splitting that popup blocking test into its own test.
Blocks: 1085609, 1083879
Ok, I'll look into it then ! Thanks for the directions !
Assignee: nobody → ricard.robin
Status: NEW → ASSIGNED
Create a new test
Attachment #8567887 - Flags: feedback?(margaret.leibovic)
Create a new test
Attachment #8567887 - Attachment is obsolete: true
Attachment #8567887 - Flags: feedback?(margaret.leibovic)
Attachment #8568043 - Flags: review?(margaret.leibovic)
Comment on attachment 8568043 [details] [diff] [review]
Split testDoorHanger in smaller test cases

Review of attachment 8568043 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Let's get a try run, and let's = also try re-enabling testDoorHanger on 2.3 devices, since this will hopefully address that intermittent issue.
Attachment #8568043 - Flags: review?(margaret.leibovic) → review+
Ok :) This just need a small rebase for me locally.
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.