Only show one Login doorhanger at a time

RESOLVED FIXED in Firefox 40

Status

()

Firefox for Android
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: liuche, Assigned: liuche)

Tracking

Trunk
Firefox 40
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox38 affected, firefox39 affected, firefox40 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 8567166 [details]
Screenshot: Doorhangers showing for multiple accounts

The password doorhangers should be cleared upon adding new doorhangers, otherwise we may run into the case where there are doorhangers visible for irrelevant accounts.
Don't show update/save login doorhangers at the same time. Showing a new login doorhanger should remove any previous login doorhangers.
Summary: Don't show Password doorhangers for multiple logins → Only show one Login doorhanger at a time
Created attachment 8590015 [details]
MozReview Request: bz://1135126/liuche

/r/6753 - Bug 1135126 - Only show one Login doorhanger at a time. r=ally

Pull down this commit:

hg pull -r fe05c077c281578373504be753c81c686236e80d https://reviewboard-hg.mozilla.org/gecko/
Attachment #8590015 - Flags: review?(ally)
Comment on attachment 8590015 [details]
MozReview Request: bz://1135126/liuche

https://reviewboard.mozilla.org/r/6751/#review5831

Ship It!
Attachment #8590015 - Flags: review?(ally) → review+
https://hg.mozilla.org/integration/fx-team/rev/7807b2f2c9e6
QA Contact: liuche
Target Milestone: --- → Firefox 40
https://hg.mozilla.org/mozilla-central/rev/7807b2f2c9e6
Assignee: nobody → liuche
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Scenario:
1. Go to gmail.com 
2. log in with username:a and password: b => remember login for username "a"
3. log in with username:a and password: c => dismiss "update password" doorhanger
4. log in with username:d and password: e => only the remember login for username "d" is displayed

Verified as fixed using:
Device: Nexus 5 (Android 5.0)
Build: Firefox for Android 40.0a1 (2015-04-22)
status-firefox38: --- → affected
status-firefox39: --- → affected
status-firefox40: fixed → verified
Comment on attachment 8590015 [details]
MozReview Request: bz://1135126/liuche
Attachment #8590015 - Attachment is obsolete: true
Attachment #8619547 - Flags: review+
Created attachment 8619547 [details]
MozReview Request: Bug 1135126 - Only show one Login doorhanger at a time. r=ally
You need to log in before you can comment on or make changes to this bug.