1135131 - remove support for json file format from talos configuration.py

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

right now configuration.py has support for json and yaml, we only use yaml, so lets make that our default.

We could effectively remove all abstraction code around the reading/writing of the specific format as well as detecting filenames and types.

Comment 1

[Ujjwal Wahi [:ujjwal]]

Attachment: bug-1135131-remove-json.diff

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8571407 [details] [diff] [review]
bug-1135131-remove-json.diff

Review of attachment 8571407 [details] [diff] [review]:
-----------------------------------------------------------------

I really like this patch- lets push a bit harder and see if we can remove even more lines of code as recommended.

::: talos/configuration.py
@@ +51,2 @@
>  
>  if yaml:

could we remove this if yaml line?

@@ +470,2 @@
>  
> +        provider = self.configuration_provider_from_format(format)

we could get rid of the filename2format, and this configuration_provider_from_format.  Both the functions and the lines here in serialize could be removed since we have just yml and can assume the sole type.  No need to adjust the extensions either.

@@ +486,4 @@
>  
>          # deserialize the data
> +        provider = self.configuration_provider_from_format(format)
> +        if not provider:

I think this stuff could be simplified knowing we only have .yml support!

Comment 3

[Ujjwal Wahi [:ujjwal]]

Attachment: bug-1135131-remove-json.diff

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8571472 [details] [diff] [review]
bug-1135131-remove-json.diff

Review of attachment 8571472 [details] [diff] [review]:
-----------------------------------------------------------------

this looks great!

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/build/talos/rev/f13f82b89d7c