1135181 - Make nsCSSRuleProcessor::Startup() infallible

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

nsCSSRuleProcessor::Startup has a return-type of nsresult (and its caller, nsLayoutStatics::Initialize, has code to handle failure).

But it always returns NS_OK. So it should just return void, and we should drop the failure-handling code.

Comment 1

[Daniel Holbert [:dholbert]]

Historical notes:

* It looks like this ::Startup method used to return void, but it was made fallible (w/ return type nsresult) here:
  http://hg.mozilla.org/mozilla-central/rev/d03d64716ccd#l2.106
to allow for the "NS_ENSURE_TRUE(gPrivateBrowsingObserver, NS_ERROR_OUT_OF_MEMORY);" line there.

This NS_ENSURE_TRUE line and the nsresult return-type were briefly removed in http://hg.mozilla.org/mozilla-central/rev/9786ae3984b3#l2.105 , but that cset was backed out in http://hg.mozilla.org/mozilla-central/rev/81086dc562b0 .

Later on, the NS_ENSURE_TRUE line was removed again, in http://hg.mozilla.org/mozilla-central/rev/cf941140cded#l1.98 , and that stuck -- but we didn't update the function-signature to make it return void this time.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a6fbf447544

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4a6fbf447544