Closed Bug 1135234 Opened 9 years ago Closed 9 years ago

Use "serif" and "sans-serif" in reader mode controls to match desktop

Categories

(Firefox for Android Graveyard :: Reader View, defect)

35 Branch
defect
Not set
normal

Tracking

(firefox38 verified, fennec38+)

VERIFIED FIXED
Firefox 38
Tracking Status
firefox38 --- verified
fennec 38+ ---

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file, 1 obsolete file)

      No description provided.
This will also fix a regression I noticed where we didn't set the correct selected font style when opening the popup, since we didn't migrate the pref value if the user had changed the value before.
tracking-fennec: --- → 38+
/r/4113 - Bug 1135234 - Use "serif" and "sans-serif" in reader mode controls to match desktop

Pull down this commit:

hg pull review -r 2133c4d475ea326f5fe8115e1b8a08723f5af092
Attachment #8567305 - Flags: review?(bnicholson)
Comment on attachment 8567305 [details]
MozReview Request: bz://1135234/margaret

https://reviewboard.mozilla.org/r/4111/#review3285
Attachment #8567305 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/65ced0c5e689
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Tapping on the "Layout options" (Aa) from the toolbar, "Serif" and "Sans-serif" fonts are displayed.
The text of the page is changing according to the selected font, so:
Verified as fixed on;
Device: LG Nexus 4 (Android 4.4)
Build: Firefox for Android 38.0a1 (2015-02-22)
Status: RESOLVED → VERIFIED
Attachment #8567305 - Attachment is obsolete: true
Attachment #8619548 - Flags: review+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: