1135234 - Use "serif" and "sans-serif" in reader mode controls to match desktop

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Comment 1

[:Margaret Leibovic]

This will also fix a regression I noticed where we didn't set the correct selected font style when opening the popup, since we didn't migrate the pref value if the user had changed the value before.

Comment 2

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1135234/margaret

/r/4113 - Bug 1135234 - Use "serif" and "sans-serif" in reader mode controls to match desktop

Pull down this commit:

hg pull review -r 2133c4d475ea326f5fe8115e1b8a08723f5af092

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8567305 [details]
MozReview Request: bz://1135234/margaret

https://reviewboard.mozilla.org/r/4111/#review3285

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/65ced0c5e689

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/65ced0c5e689

Comment 6

[Teodora Vermesan (:TeoVermesan)]

Tapping on the "Layout options" (Aa) from the toolbar, "Serif" and "Sans-serif" fonts are displayed.
The text of the page is changing according to the selected font, so:
Verified as fixed on;
Device: LG Nexus 4 (Android 4.4)
Build: Firefox for Android 38.0a1 (2015-02-22)

Comment 8

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1135234 - Use "serif" and "sans-serif" in reader mode controls to match desktop