1135336 - convert makefile rules in MailNews with props2arrays.py to use moz.build GENERATED_FILES

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Philip Chee]

https://treeherder.mozilla.org/logviewer.html#?job_id=10567&repo=comm-central

> make[5]: Entering directory `/builds/slave/tb-c-cen-lx-000000000000000000/build/objdir-tb/mailnews/intl'
> mkdir -p '.deps/'
> Unified_cpp_mailnews_intl0.o
> /usr/bin/ccache /tools/gcc-4.7.3-0moz1/bin/g++ -m32 -march=pentiumpro -o Unified_cpp_mailnews_intl0.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /builds/slave/tb-c-cen-lx-000000000000000000/build/mozilla/config/gcc_hidden.h -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_GLUE_IN_PROGRAM -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/builds/slave/tb-c-cen-lx-000000000000000000/build/mailnews/intl -I. -I/builds/slave/tb-c-cen-lx-000000000000000000/build/mozilla/intl/locale -I../../dist/include -I/builds/slave/tb-c-cen-lx-000000000000000000/build/objdir-tb/dist/include/nspr -I/builds/slave/tb-c-cen-lx-000000000000000000/build/objdir-tb/dist/include/nss -fPIC -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF .deps/Unified_cpp_mailnews_intl0.o.pp -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -DNDEBUG -DTRIMMED -g -freorder-blocks -Os -fno-omit-frame-pointer /builds/slave/tb-c-cen-lx-000000000000000000/build/objdir-tb/mailnews/intl/Unified_cpp_mailnews_intl0.cpp
> In file included from /builds/slave/tb-c-cen-lx-000000000000000000/build/objdir-tb/mailnews/intl/Unified_cpp_mailnews_intl0.cpp:2:0:
> /builds/slave/tb-c-cen-lx-000000000000000000/build/mailnews/intl/nsCharsetAlias.cpp:21:37: fatal error: charsetalias.properties.h: No such file or directory
> compilation terminated.
> make[5]: *** [Unified_cpp_mailnews_intl0.o] Error 1
> make[5]: Leaving directory `/builds/slave/tb-c-cen-lx-000000000000000000/build/objdir-tb/mailnews/intl'

Comment 1

[Edmund Wong (:ewong)]

Pushed to try-comm-central:
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=110272e1552e

Comment 2

[Edmund Wong (:ewong)]

Attachment: Fix moz.build in mailnews/intl.

proposed patch.

Comment 3

[Edmund Wong (:ewong)]

Attachment: proposed patch (v2)

Comment 5

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=10602
repository: comm-central
start_time: 2015-02-21T03:04:21
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-linux64-spot-244
buildname: TB Linux x86-64 comm-central nightly
revision: 274371a1c41f

/builds/slave/tb-c-cen-l64-ntly-000000000000/build/mailnews/intl/nsCharsetAlias.cpp:21:37: fatal error: charsetalias.properties.h: No such file or directory
make[5]: *** [Unified_cpp_mailnews_intl0.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 6

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=10566
repository: comm-central
start_time: 2015-02-20T18:21:59
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-linux64-spot-256
buildname: TB Linux comm-central leak test build
revision: 274371a1c41f

/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/intl/nsCharsetAlias.cpp:21:37: fatal error: charsetalias.properties.h: No such file or directory
make[5]: *** [Unified_cpp_mailnews_intl0.o] Error 1
make[4]: *** [mailnews/intl/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 7

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=10567
repository: comm-central
start_time: 2015-02-20T18:22:00
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-linux64-spot-270
buildname: TB Linux comm-central build
revision: 274371a1c41f

/builds/slave/tb-c-cen-lx-000000000000000000/build/mailnews/intl/nsCharsetAlias.cpp:21:37: fatal error: charsetalias.properties.h: No such file or directory
make[5]: *** [Unified_cpp_mailnews_intl0.o] Error 1
make[4]: *** [mailnews/intl/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 8

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=10565
repository: comm-central
start_time: 2015-02-20T18:21:58
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-linux64-spot-1042
buildname: TB Linux x86-64 comm-central leak test build
revision: 274371a1c41f

/builds/slave/tb-c-cen-l64-d-000000000000000/build/mailnews/intl/nsCharsetAlias.cpp:21:37: fatal error: charsetalias.properties.h: No such file or directory
make[5]: *** [Unified_cpp_mailnews_intl0.o] Error 1
make[4]: *** [mailnews/intl/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 9

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=10562
repository: comm-central
start_time: 2015-02-20T18:22:08
who: mkmelin+mozilla[at]iki[dot]fi
machine: b-2008-ix-0094
buildname: TB WINNT 5.2 comm-central leak test build
revision: 274371a1c41f

c:\builds\moz2_slave\tb-c-cen-w32-d-000000000000000\build\mailnews\intl\nsCharsetAlias.cpp(21) : fatal error C1083: Cannot open include file: 'charsetalias.properties.h': No such file or directory
mozmake.exe[5]: *** [Unified_cpp_mailnews_intl0.obj] Error 2
mozmake.exe[4]: *** [mailnews/intl/target] Error 2
mozmake.exe[4]: *** Waiting for unfinished jobs....
mozmake.exe[3]: *** [compile] Error 2
mozmake.exe[2]: *** [default] Error 2
mozmake.exe[1]: *** [build] Error 2
mozmake.exe: *** [build] Error 2

Comment 10

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=10604
repository: comm-central
start_time: 2015-02-21T03:02:53
who: mkmelin+mozilla[at]iki[dot]fi
machine: b-2008-ix-0065
buildname: TB WINNT 5.2 comm-central nightly
revision: 274371a1c41f

c:\builds\moz2_slave\tb-c-cen-w32-ntly-000000000000\build\mailnews\intl\nsCharsetAlias.cpp(21) : fatal error C1083: Cannot open include file: 'charsetalias.properties.h': No such file or directory
mozmake.exe[5]: *** [Unified_cpp_mailnews_intl0.obj] Error 2
mozmake.exe[4]: *** [mailnews/intl/target] Error 2
mozmake.exe[4]: *** Waiting for unfinished jobs....
mozmake.exe[3]: *** [compile] Error 2
mozmake.exe[2]: *** [default] Error 2
mozmake.exe[1]: *** [build] Error 2
mozmake.exe: *** [build] Error 2

Comment 11

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=10564
repository: comm-central
start_time: 2015-02-20T18:21:57
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-linux64-spot-083
buildname: TB Linux x86-64 comm-central build
revision: 274371a1c41f

/builds/slave/tb-c-cen-l64-00000000000000000/build/mailnews/intl/nsCharsetAlias.cpp:21:37: fatal error: charsetalias.properties.h: No such file or directory
make[5]: *** [Unified_cpp_mailnews_intl0.o] Error 1
make[4]: *** [mailnews/intl/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 12

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=10605
repository: comm-central
start_time: 2015-02-21T03:02:50
who: mkmelin+mozilla[at]iki[dot]fi
machine: bld-lion-r5-008
buildname: TB OS X 10.7 comm-central nightly
revision: 274371a1c41f

/builds/slave/tb-c-cen-osx64-ntly-0000000000/build/mailnews/intl/nsCharsetAlias.cpp:21:10: fatal error: 'charsetalias.properties.h' file not found
make[6]: *** [Unified_cpp_mailnews_intl0.o] Error 1
make[5]: *** [mailnews/intl/target] Error 2
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [compile] Error 2
make[3]: *** [default] Error 2
make[2]: *** [build] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 13

[Edmund Wong (:ewong)]

Comment on attachment 8567468 [details] [diff] [review]
proposed patch (v2)

Pushed to try-comm-central:
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=3a5be7b23672
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=46fdee0d97cd

(forgot osx64 on the first push)

Comment 14

[Magnus Melin [:mkmelin]]

Comment on attachment 8567468 [details] [diff] [review]
proposed patch (v2)

Review of attachment 8567468 [details] [diff] [review]:
-----------------------------------------------------------------

I'll steal this, just confirmed it works. Thx Edmund!

Comment 15

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/d8219513e01f -> FIXED

Comment 16

[rosuav]

Currently experiencing build failures involving this commit - a TypeError from this line:

charsetalias = GENERATED_FILES['charsetalias.properties.h']

Commenting out that line (and the two following lines, which depend on it) appears to give a successful build, but presumably without that file.

Comment 17

[Joshua Cranmer [:jcranmer]]

(In reply to rosuav from comment #16)
> Currently experiencing build failures involving this commit - a TypeError
> from this line:
> 
> charsetalias = GENERATED_FILES['charsetalias.properties.h']
> 
> Commenting out that line (and the two following lines, which depend on it)
> appears to give a successful build, but presumably without that file.

You probably need to update your mozilla-central checkout as well.

Comment 18

[rosuav]

Ah, thanks. It's a complicated setup and I invariably forget something. Have reverted the commenting-out, grabbed the latest mozilla-central, and started the build over. Hopefully this will work now!