1135344 - Error if build after installing Xcode 6.3: nullability specifier '__nullable' cannot be applied to non-pointer type 'bool'

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Nomis101]

Attachment: Build Errors

After installing Xcode 6.3 6D520o I'm not able anymore to build (Yosemite) any mozilla application. I get a lot of errors in DOM:
nullability specifier '__nullable' cannot be applied to non-pointer type 'bool'
As you can see in the attachment. I have tested with mozilla-central and mozilla-release. The included version of Clang is

Apple LLVM version 6.1.0 (clang-602.0.37) (based on LLVM 3.6.0svn)
Target: x86_64-apple-darwin14.3.0
Thread model: posix

Comment 2

[Nils Ohlmeier [:drno]]

btseng as you seem to be the author of the code for PCellBroadcastChild do you have any idea how to solve this?

Comment 3

[Nils Ohlmeier [:drno]]

Apparently the code in question gets generated here: https://dxr.mozilla.org/mozilla-central/source/ipc/ipdl/ipdl/lower.py#4395

Comment 4

[Nils Ohlmeier [:drno]]

So changing that '__nullable' into '__nulable' or '__nuLLable' makes it compile again for me. But I have no idea if it is important to be exactly '__nullable'.

bent, cjones: as you guys wrote/reviewed the code in lower.py which seems to cause the issues now here can you judge if it is safe to change https://dxr.mozilla.org/mozilla-central/source/ipc/ipdl/ipdl/lower.py#4395 ?

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

I guess IPDL shouldn't be using types and variable names that are reserved...

https://treeherder.mozilla.org/#/jobs?repo=try&revision=716516d439b1

Comment 6

[Jan Jongboom [:janjongboom] (inactive)]

I really thought I went insane, XCode was updating in the background while I was working on IPDL code, and then hit this error too. Patch works for me.

Comment 7

[Mason Chang [Inactive] [:mchang]]

Patch also works for me on Yosemite 10.10.3. 

clang++ --version
Apple LLVM version 6.1.0 (clang-602.0.49) (based on LLVM 3.6.0svn)
Target: x86_64-apple-darwin14.3.0
Thread model: posix

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 8590020 [details] [diff] [review]
Patch, v1

Review of attachment 8590020 [details] [diff] [review]:
-----------------------------------------------------------------

People have been asking about this in IRC today, and I'm going to declare that I can review this.  bent can yell at me if he doesn't like the decision.

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/50d48228fd8c

Comment 10

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Thanks!

Comment 11

[sspitzer]

I owe you one for this, bent.  Thanks!

Comment 12

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to sspitzer from comment #11)
> I owe you one for this, bent.  Thanks!

Anything for you, Seth!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/50d48228fd8c

Comment 14

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Yep, Seth is right, my BlueGriffon build box failed this night and an uplift with your code in fixed everything. Thanks a zillion, Ben!

Comment 15

[Alex Kontos]

After applying the patch, trying to build Firefox 37.0.1 on Yosemite 10.10.3 with XCode 6.3 results in:

NameError: global name 'otherprocess' is not defined

I don't seem to see the reason why that's happening? Should I file a new bug for this?

Comment 16

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to Alex Kontos from comment #15)
> I don't seem to see the reason why that's happening? Should I file a new bug
> for this?

Yes, this bug is done.

Comment 17

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8590020 [details] [diff] [review]
Patch, v1

Approval Request Comment
[Feature/regressing bug #]: IPDL code generation has been like this for years
[User impact if declined]: Newer XCode won't build FF any more
[Describe test coverage new/current, TreeHerder]: Any problems will cause compile errors, not runtime errors.
[Risks and why]: Apple updated XCode and our code generator used a name that the new compiler reserved for itself. This patch simply renames some variables to let the build succeed.
[String/UUID change made/needed]: None

Comment 18

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8590020 [details] [diff] [review]
Patch, v1

Should be in 38 beta 4.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1295e623a39d

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8340415e7b27