1135364 - close <meta> tag in aboutReader.html

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect)

Description

[Abdelrahman Ahmed [:abdelrahman]]

close <meta> tag by adding trailing slash in aboutReader.html

https://dxr.mozilla.org/mozilla-central/source/toolkit/components/reader/content/aboutReader.html#5

Comment 1

[Boris Kudryavtsev [:bkudryavtsev]]

Attachment: rev1 - Close <meta> tag

Comment 2

[Kyle Thomas]

Hi, I'm new to open source and trying to get involved and this bug looked like an easy starting point. I have fixed it on my local build and would like to know how I can submit my patch for review. It would also be great if I could have this bug assigned to me. (I'm in an open source class and would like to have a record of what I've worked on.) Thanks in advance for the help!

Comment 3

[Kyle Thomas]

Attachment: aboutReader.html

Is this how I'm supposed to submit a patch? Sorry. Again, I'm new to all of this.

Comment 4

[Kyle Thomas]

Never mind, I didn't realize the post above mine was also a patch request until I had already posted. Sorry, like I said, I'm new to all of this.

Comment 5

[Abdelrahman Ahmed [:abdelrahman]]

(In reply to Kyle Thomas from comment #3)
> Created attachment 8567767 [details] [diff] [review]
> aboutReader.html
> 
> Is this how I'm supposed to submit a patch? Sorry. Again, I'm new to all of
> this.

Hi Kyle,
You can start with developer guide (https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide)
and also there are some tutorials on codefirefox (http://codefirefox.com)
becasue this patch does not seem to be correct and feel free to ask me if
you have a problem with it.

(In reply to Kyle Thomas from comment #4)
> Never mind, I didn't realize the post above mine was also a patch request
> until I had already posted. Sorry, like I said, I'm new to all of this.

Sorry, this bug will be assigned to Boris because his patch seems to be ok
and he submitted it before you.

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8567588 [details] [diff] [review]
rev1 - Close <meta> tag

Review of attachment 8567588 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great. Thanks!

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

There really is no reason to do this, it's just wasted bytes.

Comment 8

[Brian Nicholson (:bnicholson)]

No reason in terms of correctness, sure, but it's a small bit of cleanup to keep the two <meta> lines consistent (one was closed, one was not).

Comment 9

[Matthew N. [:MattN]]

Drive-by: I believe we could also shorten this to: <meta charset="utf-8" />

https://hg.mozilla.org/integration/fx-team/rev/26881868e390

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/26881868e390

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for 38

Approval Request Comment
[Feature/regressing bug #]: reading list/reader mode
[User impact if declined]: 38 will have partial reading list/reader mode support
[Describe test coverage new/current, TreeHerder]: automated tests and manual tests
[Risks and why]: none expected
[String/UUID change made/needed]: none

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for 38

Approval Request Comment
[Feature/regressing bug #]: reading list/reader mode
[User impact if declined]: 38 will have partial reading list/reader mode support
[Describe test coverage new/current, TreeHerder]: automated tests and manual tests
[Risks and why]: none expected
[String/UUID change made/needed]: none

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8583400 [details] [diff] [review]
Patch for 38

It looks like reading list/reader mode has broad approval and I can just use a=readinglist

https://hg.mozilla.org/releases/mozilla-aurora/rev/fa8645257f11 for reference

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a024d69753b4

Comment 15

[Andrei Vaida [:avaida]]

Boris, is manual QA verification required here? If so, could you please expand a bit on how should we proceed?

Comment 16

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

No need.