Closed
Bug 1135537
Opened 9 years ago
Closed 9 years ago
DebugOnly.h needed for DebugOnly uses in SavedStacks
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: dougc, Assigned: dougc)
Details
Attachments
(1 file, 2 obsolete files)
1.35 KB,
patch
|
dougc
:
review+
|
Details | Diff | Splinter Review |
Looks like js/src/vm/SavedStacks.cpp needs to include mozilla/DebugOnly.h for the DebugOnly uses. Tickled a compile failure here. Introduced in bug 1117242.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8567723 -
Flags: review?(nfitzgerald)
Updated•9 years ago
|
Component: JavaScript Engine: JIT → JavaScript Engine
Summary: JIT: DebugOnly.h needed for DebugOnly uses. → DebugOnly.h needed for DebugOnly uses in SavedStacks
Comment 2•9 years ago
|
||
Comment on attachment 8567723 [details] [diff] [review] DebugOnly.h needed for DebugOnly uses. Review of attachment 8567723 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Sorry for missing this!
Attachment #8567723 -
Flags: review?(nfitzgerald) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Just update the message. Carry forward r+.
Attachment #8567723 -
Attachment is obsolete: true
Attachment #8568200 -
Flags: review+
Assignee | ||
Comment 4•9 years ago
|
||
Requesting checking. Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d60a6ecf7e8
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•9 years ago
|
||
Sorry, fixing. Carry forward r+.
Attachment #8568200 -
Attachment is obsolete: true
Attachment #8568381 -
Flags: review+
Assignee | ||
Comment 6•9 years ago
|
||
Requesting checkin. Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=90ba55b8b7ce
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e10cea14ddc5
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e10cea14ddc5
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Comment 9•9 years ago
|
||
If there is going to be a standalone js release based on esr38, this should be fixed on that branch.
You need to log in
before you can comment on or make changes to this bug.
Description
•