1135537 - DebugOnly.h needed for DebugOnly uses in SavedStacks

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Douglas Crosher [:dougc]]

Looks like js/src/vm/SavedStacks.cpp needs to include mozilla/DebugOnly.h for the DebugOnly uses. Tickled a compile failure here. Introduced in bug 1117242.

Comment 1

[Douglas Crosher [:dougc]]

Attachment: DebugOnly.h needed for DebugOnly uses.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8567723 [details] [diff] [review]
DebugOnly.h needed for DebugOnly uses.

Review of attachment 8567723 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Sorry for missing this!

Comment 3

[Douglas Crosher [:dougc]]

Attachment: bug1135537-2.patch

Just update the message. Carry forward r+.

Comment 4

[Douglas Crosher [:dougc]]

Requesting checking. Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d60a6ecf7e8

Comment 5

[Douglas Crosher [:dougc]]

Attachment: DebugOnly.h needed for DebugOnly uses in SavedStacks.

Sorry, fixing. Carry forward r+.

Comment 6

[Douglas Crosher [:dougc]]

Requesting checkin. Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=90ba55b8b7ce

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e10cea14ddc5

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e10cea14ddc5

Comment 9

[Mike Hommey [:glandium]]

If there is going to be a standalone js release based on esr38, this should be fixed on that branch.