Closed Bug 1135537 Opened 9 years ago Closed 9 years ago

DebugOnly.h needed for DebugOnly uses in SavedStacks

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: dougc, Assigned: dougc)

Details

Attachments

(1 file, 2 obsolete files)

Looks like js/src/vm/SavedStacks.cpp needs to include mozilla/DebugOnly.h for the DebugOnly uses. Tickled a compile failure here. Introduced in bug 1117242.
Attachment #8567723 - Flags: review?(nfitzgerald)
Component: JavaScript Engine: JIT → JavaScript Engine
Summary: JIT: DebugOnly.h needed for DebugOnly uses. → DebugOnly.h needed for DebugOnly uses in SavedStacks
Comment on attachment 8567723 [details] [diff] [review]
DebugOnly.h needed for DebugOnly uses.

Review of attachment 8567723 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Sorry for missing this!
Attachment #8567723 - Flags: review?(nfitzgerald) → review+
Attached patch bug1135537-2.patch (obsolete) — Splinter Review
Just update the message. Carry forward r+.
Attachment #8567723 - Attachment is obsolete: true
Attachment #8568200 - Flags: review+
Keywords: checkin-needed
Sorry, fixing. Carry forward r+.
Attachment #8568200 - Attachment is obsolete: true
Attachment #8568381 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/e10cea14ddc5
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
If there is going to be a standalone js release based on esr38, this should be fixed on that branch.
You need to log in before you can comment on or make changes to this bug.