Modify test_that_device_info_is_populated to support running on devices with no SIM cards

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
test_that_device_info_is_populated is failing in our remote device lab because the devices currently have no SIM cards. This test has valuable coverage that should not depend on the presence of a SIM, so let's make the phone number check dependent on the test variables.
(Assignee)

Updated

3 years ago
Attachment #8568005 - Attachment description: [gaia] davehunt:bug1135721 > mozilla-b2g:master → Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/28365
Attachment #8568005 - Flags: review?(gmealer)
Comment on attachment 8568005 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/28365

Copied from Github:

Aside from my concern regarding the testvars template defaults conflicting with this assumption, this is fine. r=me after you make a decision on that.
Attachment #8568005 - Flags: review?(gmealer) → review+
(Assignee)

Comment 3

3 years ago
Concerns addressed and landed in:
https://github.com/mozilla-b2g/gaia/commit/2722edf0f20c4abfe101923035143cfd00ade5de
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.