Closed Bug 1135752 Opened 5 years ago Closed 5 years ago

Add tracking link to Beta doorhanger

Categories

(DevTools :: General, defect)

36 Branch
x86
macOS
defect
Not set

Tracking

(firefox37+ fixed, firefox38+ fixed, firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox37 + fixed
firefox38 + fixed
firefox39 --- fixed

People

(Reporter: canuckistani, Assigned: jsantell)

Details

Attachments

(1 file)

Joe - this is late-breaking, but would like to see the change uplifted to at least dev edition ( to catch 38 ) and we should consider uplift to beta 37 to capture at least some of the 37 beta cycle.
Flags: needinfo?(jwalker)
This is just a pref change, FWIW
Shouldn't the URL be https?
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8568052 - Flags: review?(jwalker)
Comment on attachment 8568052 [details] [diff] [review]
1135752-doorhanger-tracking.patch

Review of attachment 8568052 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming https, I can't think of any reason to prefer http, and many to prefer https
Attachment #8568052 - Flags: review?(jwalker) → review+
Thanks for the quick patch Jordan.
Flags: needinfo?(jwalker)
So uplifts for Fx37 and Fx38?
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #7)
> So uplifts for Fx37 and Fx38?

Yes please!
Comment on attachment 8568052 [details] [diff] [review]
1135752-doorhanger-tracking.patch

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]: We will lack tracking on who visits the developer edition page from the in-application doorhanger popup
[Describe test coverage new/current, TreeHerder]:
aurora: https://treeherder.mozilla.org/#/jobs?repo=try&revision=58fa927f198e
beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ee1027e0075

[Risks and why]: just a pref change, no risks.
[String/UUID change made/needed]:
Attachment #8568052 - Flags: approval-mozilla-beta?
Attachment #8568052 - Flags: approval-mozilla-aurora?
This is my baby, please needinfo me if y'all have any questions.
Comment on attachment 8568052 [details] [diff] [review]
1135752-doorhanger-tracking.patch

Thanks for having this ready nice and early, let's get it uplifted.
Attachment #8568052 - Flags: approval-mozilla-beta?
Attachment #8568052 - Flags: approval-mozilla-beta+
Attachment #8568052 - Flags: approval-mozilla-aurora?
Attachment #8568052 - Flags: approval-mozilla-aurora+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.