1135752 - Add tracking link to Beta doorhanger

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

We need to add a tracking link to the beta doorhanger, so we can track performance:

http://www.mozilla.org/firefox/developer/?utm_source=firefox-dev-tools&utm_medium=firefox-browser&utm_content=betadoorhanger

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Joe - this is late-breaking, but would like to see the change uplifted to at least dev edition ( to catch 38 ) and we should consider uplift to beta 37 to capture at least some of the 37 beta cycle.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

This is just a pref change, FWIW

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Shouldn't the URL be https?

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1135752-doorhanger-tracking.patch

Comment 5

[Joe Walker [:jwalker]]

Comment on attachment 8568052 [details] [diff] [review]
1135752-doorhanger-tracking.patch

Review of attachment 8568052 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming https, I can't think of any reason to prefer http, and many to prefer https

Comment 6

[Joe Walker [:jwalker]]

Thanks for the quick patch Jordan.

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

So uplifts for Fx37 and Fx38?

Comment 8

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #7)
> So uplifts for Fx37 and Fx38?

Yes please!

Comment 9

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8568052 [details] [diff] [review]
1135752-doorhanger-tracking.patch

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]: We will lack tracking on who visits the developer edition page from the in-application doorhanger popup
[Describe test coverage new/current, TreeHerder]:
aurora: https://treeherder.mozilla.org/#/jobs?repo=try&revision=58fa927f198e
beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ee1027e0075

[Risks and why]: just a pref change, no risks.
[String/UUID change made/needed]:

Comment 10

[Jeff Griffiths (:canuckistani) (:⚡︎)]

This is my baby, please needinfo me if y'all have any questions.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/e13b8f21939b

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e13b8f21939b

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8568052 [details] [diff] [review]
1135752-doorhanger-tracking.patch

Thanks for having this ready nice and early, let's get it uplifted.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c002149f2c79

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/abb350df1154