The cycle collector should not depend on QI nulling out the return value in case of failure

RESOLVED FIXED in Firefox 39

Status

()

Core
XPCOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
See the discussion in bug 723248.  This could cause some weird crashes.  The simplest thing to do is probably to just null out the return value before we call QI.  That won't help if a QI intentionally mangles the return value in case of failure, but that seems unlikely.  Bug 1135772 has some examples of QIs failing to null out the return value.
(Assignee)

Comment 1

3 years ago
Created attachment 8568242 [details] [diff] [review]
Initialize QI return values to null in the cycle collector.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=22b490430a79
(Assignee)

Updated

3 years ago
Attachment #8568242 - Flags: review?(bugs)

Updated

3 years ago
Attachment #8568242 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/2c50d60676c7
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.