1135846 - Re-organize marionette actions code to expose actions to chrome scope

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

I noticed working on bug 1097705 and bug 1129702 that action chains aren't exposed in chrome at all. I expect applicable code to work in chrome scope as-is, but we'll need to do a moderate refactor to expose it there.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

First cut at this, expecting a few things to shake out of b2g:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2aad7f0c4fca
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd9c1e137056

Comment 2

[Chris Manchester (limited bugmail, email directly)]

hg add might help:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=090ac62e18a8

Comment 3

[Chris Manchester (limited bugmail, email directly)]

b2g with fixup:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4dcdabb58c7

Comment 4

[Chris Manchester (limited bugmail, email directly)]

The result of double clicking in the url bar differs between platforms. That's weird. I have to update my test.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

(In reply to Chris Manchester [:chmanchester] from comment #4)
> The result of double clicking in the url bar differs between platforms.
> That's weird. I have to update my test.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=43455b642272

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: bz://1135846/chmanchester

/r/5039 - Bug 1135846 - Expose marionette's actions code to chrome scope where applicable.

Pull down this commit:

hg pull review -r bb74fc3e3e99e0e643af1b7316135959b9c01459

Comment 7

[Chris Manchester (limited bugmail, email directly)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a4ee438419c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d266006347e

Comment 8

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8574751 [details]
MozReview Request: bz://1135846/chmanchester

/r/5039 - Bug 1135846 - Expose marionette's actions code to chrome scope where applicable.

Pull down this commit:

hg pull review -r 606f0aa9dd17ccac2b87edc9bc5d868c5a13ce5f

Comment 9

[David Burns :automatedtester]

Comment on attachment 8574751 [details]
MozReview Request: bz://1135846/chmanchester

https://reviewboard.mozilla.org/r/5037/#review4125

::: testing/marionette/client/marionette/tests/unit/test_click_action.py
(Diff revision 2)
> +class TestClickAction(MarionetteTestCase):

instead of click can we call it Mouse since we are testing Mouse Actions

::: testing/marionette/marionette-common.js
(Diff revision 2)
> +this.ActionChain = function (utils, checkForInterrupted) {

Can we split this out into it's own area. Using common here feels like we are creating a utils class and then shoehorning ALL THE THINGS into it

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8574751 [details]
MozReview Request: bz://1135846/chmanchester

/r/5039 - Bug 1135846 - Expose marionette's actions code to chrome scope where applicable.

Pull down this commit:

hg pull review -r ad86d046b074cb576ce42f93a4824cda2cfee6dd

Comment 11

[Chris Manchester (limited bugmail, email directly)]

https://reviewboard.mozilla.org/r/5037/#review4399

::: testing/marionette/jar.mn
(Diff revision 3)
> +  content/marionette-actions.js     (marionette-actions.js)

I neglected to hg add this file

Comment 12

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8574751 [details]
MozReview Request: bz://1135846/chmanchester

/r/5039 - Bug 1135846 - Expose marionette's actions code to chrome scope where applicable.

Pull down this commit:

hg pull review -r 89bbb281c3fe82efbb52dad8f6e6c41e6718f8b4

Comment 13

[Chris Manchester (limited bugmail, email directly)]

Try with updates from review comments:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=54d8bf65da6c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b17dd7cb315

Comment 14

[David Burns :automatedtester]

https://reviewboard.mozilla.org/r/5039/#review4637

Ship It!

Comment 15

[David Burns :automatedtester]

Comment on attachment 8574751 [details]
MozReview Request: bz://1135846/chmanchester

https://reviewboard.mozilla.org/r/5037/#review4667

Ship It!

Comment 16

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8574751 [details]
MozReview Request: bz://1135846/chmanchester

/r/5039 - Bug 1135846 - Expose marionette's actions code to chrome scope where applicable.;r=dburns

Pull down this commit:

hg pull review -r 1ea05133fb61033ee7de173844254ba6bc2a8935

Comment 17

[Chris Manchester (limited bugmail, email directly)]

Try in comment 13.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6b20e7ca118

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b6b20e7ca118

Comment 21

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1135846 - Expose marionette's actions code to chrome scope where applicable.;r=dburns