Closed Bug 1135846 Opened 5 years ago Closed 5 years ago

Re-organize marionette actions code to expose actions to chrome scope

Categories

(Testing :: Marionette, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox39 fixed)

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

(Keywords: pi-marionette-server, pi-marionette-userinput)

Attachments

(1 file, 1 obsolete file)

I noticed working on bug 1097705 and bug 1129702 that action chains aren't exposed in chrome at all. I expect applicable code to work in chrome scope as-is, but we'll need to do a moderate refactor to expose it there.
The result of double clicking in the url bar differs between platforms. That's weird. I have to update my test.
(In reply to Chris Manchester [:chmanchester] from comment #4)
> The result of double clicking in the url bar differs between platforms.
> That's weird. I have to update my test.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=43455b642272
/r/5039 - Bug 1135846 - Expose marionette's actions code to chrome scope where applicable.

Pull down this commit:

hg pull review -r bb74fc3e3e99e0e643af1b7316135959b9c01459
Comment on attachment 8574751 [details]
MozReview Request: bz://1135846/chmanchester

/r/5039 - Bug 1135846 - Expose marionette's actions code to chrome scope where applicable.

Pull down this commit:

hg pull review -r 606f0aa9dd17ccac2b87edc9bc5d868c5a13ce5f
Attachment #8574751 - Flags: review?(dburns)
Attachment #8574751 - Flags: review?(dburns)
Comment on attachment 8574751 [details]
MozReview Request: bz://1135846/chmanchester

https://reviewboard.mozilla.org/r/5037/#review4125

::: testing/marionette/client/marionette/tests/unit/test_click_action.py
(Diff revision 2)
> +class TestClickAction(MarionetteTestCase):

instead of click can we call it Mouse since we are testing Mouse Actions

::: testing/marionette/marionette-common.js
(Diff revision 2)
> +this.ActionChain = function (utils, checkForInterrupted) {

Can we split this out into it's own area. Using common here feels like we are creating a utils class and then shoehorning ALL THE THINGS into it
Comment on attachment 8574751 [details]
MozReview Request: bz://1135846/chmanchester

/r/5039 - Bug 1135846 - Expose marionette's actions code to chrome scope where applicable.

Pull down this commit:

hg pull review -r ad86d046b074cb576ce42f93a4824cda2cfee6dd
Attachment #8574751 - Flags: review?(dburns)
https://reviewboard.mozilla.org/r/5037/#review4399

::: testing/marionette/jar.mn
(Diff revision 3)
> +  content/marionette-actions.js     (marionette-actions.js)

I neglected to hg add this file
Comment on attachment 8574751 [details]
MozReview Request: bz://1135846/chmanchester

/r/5039 - Bug 1135846 - Expose marionette's actions code to chrome scope where applicable.

Pull down this commit:

hg pull review -r 89bbb281c3fe82efbb52dad8f6e6c41e6718f8b4
Comment on attachment 8574751 [details]
MozReview Request: bz://1135846/chmanchester

https://reviewboard.mozilla.org/r/5037/#review4667

Ship It!
Attachment #8574751 - Flags: review?(dburns) → review+
Comment on attachment 8574751 [details]
MozReview Request: bz://1135846/chmanchester

/r/5039 - Bug 1135846 - Expose marionette's actions code to chrome scope where applicable.;r=dburns

Pull down this commit:

hg pull review -r 1ea05133fb61033ee7de173844254ba6bc2a8935
Attachment #8574751 - Flags: review+
Attachment #8574751 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6b20e7ca118
Assignee: nobody → cmanchester
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b6b20e7ca118
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Attachment #8574751 - Attachment is obsolete: true
Attachment #8619564 - Flags: review+
You need to log in before you can comment on or make changes to this bug.