Closed
Bug 1135917
Opened 10 years ago
Closed 10 years ago
Tapping the url is hard
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: wesj, Assigned: wesj)
Details
Attachments
(1 file)
Its hard to tap the urlbar right. We've tried to fix this a bit, but I think we can make it even easier (and better) by just using the horizontal locations of subviews in our hit testing.
|
Assignee | |
Comment 1•10 years ago
|
||
This just has us iterate over subviews of the VC until we find one in this touches x-range. It feels a lot better and should work fine (assuming our urlbar doesn't get much more complex).
Attachment #8568245 -
Flags: review?(sarentz)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8568245 [details] [review]
Pull request
LGTM!
Attachment #8568245 -
Flags: review?(sarentz) → review+
|
|
||
Updated•10 years ago
|
Assignee: nobody → wjohnston
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 3•10 years ago
|
||
Feels better to me
You need to log in
before you can comment on or make changes to this bug.
Description
•