Closed Bug 1135920 Opened 10 years ago Closed 10 years ago

Create a top sites panel

Categories

(Firefox for iOS :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: wesj, Assigned: bnicholson)

References

Details

Attachments

(1 file, 1 obsolete file)

We should show a top sites panel similar to Android's on about:home.
Blocks: 1130497
Attached patch WIP PR (obsolete) — Splinter Review
This is a WIP of this. It implements a custom UICollectionView layout to handle showing thumbnails up top and a list below. Works pretty well right now, but needs cleanup. No thumbnails yet. No click delegate hooked up.
Attached file Pull request
This is a start at this. I wanted to start having someone look at it now. There's lots of follows up (handling rotation better, frecency, etc), but I think its enough for a good base.
Attachment #8569007 - Attachment is obsolete: true
Attachment #8570811 - Flags: review?(sarentz)
Comment on attachment 8570811 [details] [review]
Pull request

Comments in the PR.
Attachment #8570811 - Flags: review?(sarentz) → review+
I'll fix this up and merge.
Assignee: nobody → bnicholson
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: