Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: wesj, Assigned: bnicholson)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

47 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review | Splinter Review
(Reporter)

Description

4 years ago
We should show a top sites panel similar to Android's on about:home.
(Reporter)

Updated

4 years ago
Blocks: 1130497
(Reporter)

Comment 1

4 years ago
Posted patch WIP PR (obsolete) — Splinter Review
This is a WIP of this. It implements a custom UICollectionView layout to handle showing thumbnails up top and a list below. Works pretty well right now, but needs cleanup. No thumbnails yet. No click delegate hooked up.
(Reporter)

Comment 2

4 years ago
Posted file Pull request
This is a start at this. I wanted to start having someone look at it now. There's lots of follows up (handling rotation better, frecency, etc), but I think its enough for a good base.
Attachment #8569007 - Attachment is obsolete: true
Attachment #8570811 - Flags: review?(sarentz)
Comment on attachment 8570811 [details] [review]
Pull request

Comments in the PR.
Attachment #8570811 - Flags: review?(sarentz) → review+
(Assignee)

Comment 4

4 years ago
I'll fix this up and merge.
Assignee: nobody → bnicholson
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.