Closed
Bug 1135921
Opened 10 years ago
Closed 9 years ago
Tabs tray should use a UICollectionView
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: wesj, Assigned: dhenein)
References
Details
Attachments
(1 file)
|
47 bytes,
patch
|
st3fan
:
review+
|
Details | Diff | Splinter Review |
Right now we use a UITableView for the tabs tray. The tablet version will be a grid though. We should use a CollectionView which should make switching between the two easier.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → dhenein
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8589158 [details] [diff] [review] PR 317 >https://github.com/mozilla/firefox-ios/pull/317
Attachment #8589158 -
Attachment is patch: true
Attachment #8589158 -
Attachment mime type: text/x-github-pull-request → text/plain
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8589158 -
Flags: review?(wjohnston)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8589158 -
Flags: review?(sarentz)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8589158 [details] [diff] [review] PR 317 This looks good. There still is an issue with screenshots not always being the right size. I think I triggered it by opening a few tabs and then switching back and forth between landscape/portrait (on an iPhone 5S). Lets make that be a followup bug? Can you squash the commits into 1 before you merge?
Attachment #8589158 -
Flags: review?(wjohnston) → review+
|
|
||
Updated•9 years ago
|
Attachment #8589158 -
Flags: review?(sarentz) → review?(wjohnston)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Merged: https://github.com/mozilla/firefox-ios/commit/ff6a19c5f6fed1de32fbfda7b15af63aa19ef85c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
Reporter | |
Updated•9 years ago
|
Attachment #8589158 -
Flags: review?(wjohnston)
You need to log in
before you can comment on or make changes to this bug.
Description
•