1135948 - TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | the menuitem is for a built-in sidebar - false == true

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

TEST-START | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | no sidebar is showing

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | the new window is not private

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | the sidebar is showing

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | the new window is not private

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | the sidebar is not showing

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | the sidebar is not showing

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | destroying the sidebar

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | the current window is not private

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | showing the sidebar

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | the menuitem is for a built-in sidebar

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | no sidebar menuitem is checked

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | the menuitem is for a built-in sidebar

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | no sidebar menuitem is checked

TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | the menuitem is for a built-in sidebar - false == true

TEST-INFO | Traceback (most recent call last):

  File "resource://gre/modules/Promise-backend.js", line 688, in this.PromiseWalker.scheduleWalkerLoop/<

    DOMPromise.resolve().then(() => this.walkerLoop());

  File "resource://gre/modules/Promise-backend.js", line 746, in this.PromiseWalker.walkerLoop

    this.handlers.shift().process();

  File "resource://gre/modules/Promise-backend.js", line 867, in Handler.prototype.process

    nextValue = this.onResolve.call(undefined, nextValue);

  File "resource://gre/modules/Task.jsm", line 314, in TaskImpl_run

    let result = aSendResolved ? this._iterator.next(aSendValue)

  File "self-hosted", line 620, in next

  File "self-hosted", line 712, in InterpretGeneratorResume

  File "resource://1072dfba-6e03-420c-85e4-0603b1ccb06c-at-jetpack/addon-sdk/tests/test-ui-sidebar.js", line 603, in exports.testDestroyEdgeCaseBug

    assert.ok(BUILTIN_SIDEBAR_MENUITEMS.indexOf(mi.getAttribute('id')) >= 0, 'the menuitem is for a built-in sidebar')

  File "resource://extensions.modules.1072dfba-6e03-420c-85e4-0603b1ccb06c-at-jetpack.commonjs.path/sdk/test/assert.js", line 99, in ok

    this.fail({

  File "resource://extensions.modules.1072dfba-6e03-420c-85e4-0603b1ccb06c-at-jetpack.commonjs.path/sdk/test/assert.js", line 88, in fail

    this._log.fail(message);

  File "resource://extensions.modules.1072dfba-6e03-420c-85e4-0603b1ccb06c-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 104, in fail

    this.console.testMessage(false, false, this.test.name, message);

  File "resource://extensions.modules.1072dfba-6e03-420c-85e4-0603b1ccb06c-at-jetpack.commonjs.path/sdk/test/harness.js", line 543, in testMessage

    this.trace();

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | no sidebar menuitem is checked

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | sidebar id DNE

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | the sidebar is not showing

TEST-PASS | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | no sidebar is showing

TEST-END | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: https://github.com/mozilla/addon-sdk/pull/1874

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/71bbf6393d4b7ac557ad6101e34cb7d19b29a544
Bug 1135948 - TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-ui-sidebar.testDestroyEdgeCaseBug | the menuitem is for a built-in sidebar - false == true a=me

https://github.com/mozilla/addon-sdk/commit/63ffe34c6c49be2da12d6a41c71a701c129bce45
Merge pull request #1874 from erikvold/1135948

Bug 1135948 - Adding the new reading list menuitem id to the list of known ids r=jsantell