Closed
Bug 1135992
Opened 9 years ago
Closed 9 years ago
Non-unified build failed in nsLayoutUtils.cpp
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(1 file, 1 obsolete file)
916 bytes,
patch
|
TYLin
:
review+
|
Details | Diff | Splinter Review |
While working on bug 1110039, I introduce new files to layout/base and encounter this non-unified build failed by bug 1125422. In file included from /Users/tlin/Projects/gecko-dev/obj-firefox/layout/base/Unified_cpp_layout_base2.cpp:29: /Users/tlin/Projects/gecko-dev/layout/base/nsLayoutUtils.cpp:7891:19: error: use of undeclared identifier 'EventDispatcher' ; did you mean 'EventListener'? nsresult rv = EventDispatcher::Dispatch(doc, nullptr, &event, nullptr, ^~~~~~~~~~~~~~~ EventListener
Assignee | ||
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7267f440b64
Attachment #8568354 -
Flags: review?(roc)
Comment 2•9 years ago
|
||
Comment on attachment 8568354 [details] [diff] [review] Fix non-unified build failed in nsLayoutUtils.cpp. Review of attachment 8568354 [details] [diff] [review]: ----------------------------------------------------------------- Stealing review as this is an obvious one-line fix.
Attachment #8568354 -
Flags: review?(roc) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Update the reviewer name. Botond, thanks for the review!
Attachment #8568354 -
Attachment is obsolete: true
Attachment #8568453 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/abb88e8a0a75
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/abb88e8a0a75
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•