Closed
Bug 1136023
Opened 10 years ago
Closed 10 years ago
[Stingray] create smart-bubble web components for smart screen
Categories
(Firefox OS Graveyard :: Gaia::TV, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: johnhu)
References
Details
Attachments
(1 file)
This web component is an animation component which controls other DOM element to show the animation.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → im
|
|
Assignee | |
Comment 1•10 years ago
|
||
Sung,
I had created a web component based on your previous code. Please review this patch.
Attachment #8568415 -
Flags: review?(suchiu)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8568415 [details] [review]
create smart-bubbles
It is good to me! Maybe createdCallback function can be removed since it is empty.
Attachment #8568415 -
Flags: review?(suchiu) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
merged to smart-bubble:master
https://github.com/smart-components/smart-bubbles/commit/600518ce807d8f8cddc0d0553f61738698df98b8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•