1136085 - Don't do subsessions and subsession data duplication on mobile.

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Georg Fritzsche [:gfritzsche]]

We currently duplicate the histograms on Android too and hit bug 1135166 there consistently.

We don't need any of the duplication code there now, so we should just not do any of this on Android.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Attachment: Part 1 - Don't store & collect subsession histograms on mobile

Test-fixes for this are still coming up, but i'd rather get this to you early.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Attachment: Part 2 - Don't do session splits on mobile

Test-fixes for this are still coming up, but i'd rather get this to you early.

Comment 3

[Georg Fritzsche [:gfritzsche]]

Attachment: Part 3 - Test fixups

Comment 4

[Vladan Djeric (:vladan)]

Comment on attachment 8568759 [details] [diff] [review]
Part 3 - Test fixups

Review of attachment 8568759 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/tests/unit/head.js
@@ +6,5 @@
>  
> +const gIsWindows = ("@mozilla.org/windows-registry-key;1" in Components.classes);
> +const gIsMac = ("@mozilla.org/xpcom/mac-utils;1" in Components.classes);
> +const gIsAndroid =  ("@mozilla.org/android/bridge;1" in Components.classes);
> +const gIsGonk = ("@mozilla.org/cellbroadcast/gonkservice;1" in Components.classes);

Could you use Services.appinfo.OS here?

Comment 5

[Georg Fritzsche [:gfritzsche]]

Pushed in: https://hg.mozilla.org/integration/fx-team/pushloghtml?changeset=b83c3fa8c80f

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7eb7fb731f39
https://hg.mozilla.org/mozilla-central/rev/5a284958c7aa
https://hg.mozilla.org/mozilla-central/rev/68e5ab6b33f7