Closed Bug 1136208 Opened 9 years ago Closed 9 years ago

Rename various references of related in Firefox

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Type:
defect
Priority:
Not set
Severity:
normal
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Iteration:
39.3 - 30 Mar
Tracking Flags:
Tracking Status
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: Mardak, Assigned: emtwo)

References

Details

(Whiteboard: .?)

Attachments

(1 file)

v1: Change all references of 'related' to 'suggested'
26.08 KB, patch
adw
: review+
Details | Diff | Splinter Review 
This might involve some Firefox and splice changes. We just want to be consistent to have our variables/references match up with the descriptions we use to show users. It should make it easier for searching through the code to find the relevant pieces.
I'm not sure what the variable name should be... some suggestions: suggestedFor or because we expect different types down the line: suggestSites vs suggestRecent vs suggestSearch?
I like the suggest* prefix, though in Python, anyway it will be suggest_sites, suggest_recent, suggest_search, etc
Assignee: nobody → msamuel
Summary: Rename various references of related → Rename various references of related in Firefox
Attachment #8583965 - Flags: review?(adw) → review+
Iteration: --- → 39.3 - 30 Mar
Points: --- → 5
https://hg.mozilla.org/mozilla-central/rev/a2a653839bca
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Blocks: 1148859
Flags: qe-verify-
Blocks: 1155443
No longer blocks: 1155443
You need to log in before you can comment on or make changes to this bug.