Unify Reader View type options to be Sans-Serif on Left, Serif on Right

VERIFIED FIXED in Firefox 38

Status

()

Firefox for Android
Reader View
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: antlam, Assigned: Margaret)

Tracking

unspecified
Firefox 39
x86
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox38 verified, firefox39 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
As per our IRC convo, just defaulting to the left (Sans-serif).

Consistent across Android, iOS, and Desktop.
(Reporter)

Updated

3 years ago
Flags: needinfo?(margaret.leibovic)
OS: Mac OS X → Android
(Reporter)

Updated

3 years ago
Blocks: 1120004
(Assignee)

Updated

3 years ago
Assignee: nobody → margaret.leibovic
Flags: needinfo?(margaret.leibovic)
(Assignee)

Comment 2

3 years ago
Created attachment 8568751 [details]
MozReview Request: bz://1136231/margaret

/r/4251 - Bug 1136231 - Unify Reader View type options to be Sans-Serif on Left, Serif on Right. r=bnicholson

Pull down this commit:

hg pull review -r efc517aba91c072b25a52b20ab3c717b763c040c
Attachment #8568751 - Flags: review?(bnicholson)
Comment on attachment 8568751 [details]
MozReview Request: bz://1136231/margaret

https://reviewboard.mozilla.org/r/4249/#review3419

Ship It!
Attachment #8568751 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/8f6fd5d64969
Blocks: 558882
status-firefox38: --- → affected
https://hg.mozilla.org/mozilla-central/rev/8f6fd5d64969
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Tapping on the "Layout options" (Aa) from the toolbar, "Sans-serif" and "Serif" fonts are displayed.
Verified as fixed on;
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 39.0a1 (2015-03-01)
Status: RESOLVED → VERIFIED
status-firefox39: fixed → verified
(Assignee)

Comment 7

3 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/fa8645257f11
status-firefox38: affected → fixed
Tapping on the "Layout options" (Aa) from the reader mode toolbar, "Sans-serif" is displayed left and "Serif" is displayed right.
Verified as fixed on;
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 38.0a2 (2015-03-06)
status-firefox38: fixed → verified
(Assignee)

Comment 9

3 years ago
Comment on attachment 8568751 [details]
MozReview Request: bz://1136231/margaret
Attachment #8568751 - Attachment is obsolete: true
Attachment #8619576 - Flags: review+
(Assignee)

Comment 10

3 years ago
Created attachment 8619576 [details]
MozReview Request: Bug 1136231 - Unify Reader View type options to be Sans-Serif on Left, Serif on Right. r=bnicholson
You need to log in before you can comment on or make changes to this bug.