1136291 - new non-e10s windows have tabs shifted down

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Josh Aas]

Attachment: ff-screenshot.png

1. Download Nightly, run it
2. Close all windows
3. Open a non-e10s window

The window opens with tabs shifted down out of the title bar. This is a recent regression, last 24-48 hours I think.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I get this:
TypeError: sourceUI._box is null browser.js:6992:8

Sounds related to bug 1123517 part 1.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Skippy to the rescue!

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(If it wasn't clear, I was referring to markh, who has a working patch for this already.)

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-1136291-better-handle-an-unexpected-eg-the-hidde.patch

Comment 6

[Mark Hammond [:markh] [:mhammond]]

https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=46be8d043c5a

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/46be8d043c5a

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8568895 [details] [diff] [review]
0001-Bug-1136291-better-handle-an-unexpected-eg-the-hidde.patch

Approval Request Comment
[Feature/regressing bug #]: 1123517
[User impact if declined]: Broken browser in some situations.
[Describe test coverage new/current, TreeHerder]: All still pass
[Risks and why]: None
[String/UUID change made/needed]: None

Comment 9

[Mark Hammond [:markh] [:mhammond]]

[Tracking Requested - why for this release]:

We really want this for 38.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8a0d1a42bb4c

Comment 11

[Petruta Horea [:phorea], Desktop Test Engineering]

Reproduced on 2015-02-24 Nightly build under Mac OS X 10.9.5.
Verified as fixed using Nightly 39.0a1 and Aurora 38.0a2 2015-03-09.