1136292 - Stop passing explicit "JS::NullPtr()" or "global" args to JS_NewObjectWithGivenProto

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The three-arg form defaults to using the global as proto, and it'd be nice to just get rid of the four-arg form....

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Stop passing a parent to BindingJSObjectCreator methods, since it's always the global anyway

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Stop passing an explicit JS::NullPtr parent to JS_NewObjectWithGivenProto in nsDocument

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Stop passing a global as the parent arg to JS_NewObjectWithGivenProto in bindings code

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Stop passing a global as the parent arg to JS_NewObjectWithGivenProto in XBL code

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Stop passing a global as the parent arg to JS_NewObjectWithGivenProto in XPConnect

Comment 6

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/827eadf15cf0
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7d3b11d8765
https://hg.mozilla.org/integration/mozilla-inbound/rev/13fe99535f2b
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9549bacf53c
https://hg.mozilla.org/integration/mozilla-inbound/rev/06227342cd2e

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/827eadf15cf0
https://hg.mozilla.org/mozilla-central/rev/c7d3b11d8765
https://hg.mozilla.org/mozilla-central/rev/13fe99535f2b
https://hg.mozilla.org/mozilla-central/rev/e9549bacf53c
https://hg.mozilla.org/mozilla-central/rev/06227342cd2e