Closed Bug 1136309 Opened 7 years ago Closed 7 years ago

Fix up the spidermonkey build names to reflect reality

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox38 --- fixed
firefox38.0.5 --- fixed
firefox39 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(4 files)

SM(ggc) tests compacting GC. Windows SM(e) does not fail if there are warnings.
Attached patch Fix variantsSplinter Review
This makes 'plain' and 'plaindebug' variants for Windows, moves everything under a variants/ subdir to make things easier to see, and renames 'generational' -> 'compacting' (except it leaves the old one around so we can land this patch first.)
Attachment #8568698 - Flags: review?(terrence)
buildbot side of things, to be landed after the in-tree changes have stuck.
Attachment #8568699 - Flags: review?(terrence)
Attachment #8568698 - Attachment is obsolete: true
Attachment #8568698 - Flags: review?(terrence)
Comment on attachment 8568698 [details] [diff] [review]
Fix variants

Dammit, I named the mq patches for the different repos the same thing again.
Attachment #8568698 - Attachment is obsolete: false
Attachment #8568698 - Flags: review?(terrence)
Attachment #8568744 - Flags: review?(terrence)
Comment on attachment 8568744 [details] [diff] [review]
Add in new spidermonkey builds

Oops, while using git-bz attach for the first time, I set the wrong reviewer.
Attachment #8568744 - Flags: review?(terrence) → review?(emorley)
Attachment #8568750 - Flags: review?(emorley)
Comment on attachment 8568744 [details] [diff] [review]
Add in new spidermonkey builds

lgtm - if you open as a PR I can directly merge it, or if you have access you're welcome to land directly :-)
Attachment #8568744 - Flags: review?(emorley) → review+
Attachment #8568750 - Flags: review?(emorley) → review+
Attachment #8568698 - Flags: review?(terrence) → review+
Attachment #8568699 - Flags: review?(terrence) → review+
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/30fa485911681bf16eb6a6edb46706b65098d5de
Bug 1136309 - Document the new spidermonkey builds

https://github.com/mozilla/treeherder-ui/commit/bac15b2957e594d8a018adbc308a31bc8219db9d
Merge pull request #396 from hotsphink/F-new-SM-builds

Bug 1136309 - Document the new spidermonkey builds
Keywords: leave-open
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/dbac2940288e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Attachment #8568699 - Flags: checkin+
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ff687fc65cf3273c778107c0094b1f9a63a198dd
Bug 1136309 - Document the new spidermonkey builds

https://github.com/mozilla/treeherder/commit/c66f936ac1c1b16231687961b53ad29a3d6fc815
Merge pull request #396 from hotsphink/F-new-SM-builds

Bug 1136309 - Document the new spidermonkey builds
You need to log in before you can comment on or make changes to this bug.