Closed Bug 1136365 Opened 10 years ago Closed 9 years ago

Letter box video with black stripes

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla42
Iteration:
42.2 - Jul 27

People

(Reporter: drno, Assigned: sevaan)

References

Details

(Whiteboard: [fixed by bug 1180179])

Attachments

(2 files)

Attached image letterboxvideo.png
In my call today with mreavy her video suddenly got rendered in letter box format. I actually like the 16:9 aspect ratio, better then the old format. But the black stripes at top and bottom are really ugly. Can we resize the conversation window to the size of the video, please?
Nils, the screenshot is the popped-out window which you can resize yourself. Have I misunderstood the issue here?
Flags: needinfo?(drno)
(In reply to Mark Banner (:standard8) from comment #1) > Nils, the screenshot is the popped-out window which you can resize yourself. Well I never resized it, besides clicking the arrow for popping it out. I'm not sure if the original window also had the black stripes. But Maire indicated that she even saw the black stripes in her own preview. I'm not able to reproduce the problem if I call myself. Probably my build in cam does not provide letter box format. I'll try to re-test with Maire.
Attached image conversation169.png
Dang it I forgot to try to resize the popped out conversation window. But as you can see from the attached screen shot, the "problem" of the black stripes, or in other words "loop video rendering areas not adjusting to aspect ratio of the incoming video stream", also exists with the small conversation window.
Flags: needinfo?(drno)
Passing to Sevaan, though I don't think there's much we can do here - short of potentially dynamically resizing the window, which imo would feel a bit weird.
Assignee: nobody → sfranks
(In reply to Mark Banner (:standard8) from comment #4) > Passing to Sevaan, though I don't think there's much we can do here - short > of potentially dynamically resizing the window, which imo would feel a bit > weird. I'm actually in favor of dynamically resizing here. But I agree that resizing the small conversation window could feel strange. What I think would be reasonable is to leave the small conversation window at its fixed initial size. But once the call is connected we should know the size and aspect ratio of the remote stream. So if someone pops out the conversation window after the call connected / someone joined the room (which always my use case), then it would be nice if we could make the aspect ratio of the popped out window depending on the aspect ratio of the remote video to avoid the "mourning stripes".
I like :drno's suggestion. Keep the conversation window as is, but if the window is popped out, resize it correctly.
This is going to be fixed by the ux-refresh, or possibly one of the bugs surrounding that.
Depends on: 1138445, 1180179
(because we'll be using an object-fit: cover for the remote video)
This is now fixed on desktop by bug 1180179. Note: Local video may still have letterbox in the preview window - this is to ensure the user can see everything that may be seen by the receiver (privacy).
Status: NEW → RESOLVED
Iteration: --- → 42.2 - Jul 27
Closed: 9 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [fixed by bug 1180179]
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: