Closed Bug 1136393 Opened 10 years ago Closed 10 years ago

Play control button labels are not localized

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S7 (6mar)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

(Keywords: access, late-l10n, Whiteboard: [b2ga11y p=1])

Attachments

(1 file)

[gaia] eeejay:bug-1136393 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
squib
: review+
bajaj
: approval-gaia-v2.2+
Details | Review
In the player view, we use ::before styling and an attribute to style the label. We also need a localized string label for accessibility.
Attachment #8568845 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8568845 [details] [review] [gaia] eeejay:bug-1136393 > mozilla-b2g:master Looks good!
Attachment #8568845 - Flags: review?(squibblyflabbetydoo) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8568845 [details] [review] [gaia] eeejay:bug-1136393 > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: Play control buttons won't be localizeable and perceivable to screen reader. [Testing completed]: Yes. It has been on master for a while. [Risk to taking this patch] (and alternatives if risky): Low. [String changes made]: yes, added labels for screen reader.
Attachment #8568845 - Flags: approval-gaia-v2.2?
Attachment #8568845 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: