Closed Bug 1136396 Opened 10 years ago Closed 9 years ago

Typing indicator makes latest message hard to read

Categories

(Instantbird Graveyard :: Conversation, defect)

Product:
Instantbird Graveyard
Component:
Conversation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Instantbird 42

People

(Reporter: u494412, Assigned: aleth)

Details

(Whiteboard: [1.6-blocking])

Attachments

(2 files)

test 1.PNG
28.11 KB, image/png
Details
typingright.diff.diff
2.81 KB, patch
nhnt11
: review+
clokep
: feedback+
Details | Diff | Splinter Review
Attached image test 1.PNG — 
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.115 Safari/537.36

Steps to reproduce:

Wait for recipient to respond to a message


Actual results:

The typing indicator covers up the beginning of the last line of text and partially the second to last line of text


Expected results:

I should be able to see the last line of text
Version: 1.5 → trunk
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [1.6-blocking]
It would be quite hard to "move up" the conversation contents in a way that works for all message styles.

Would it be enough to move the typing notification to the right hand side?

Is the real problem that typing notifications, in particular "x has stopped typing", stay on the screen for too long?

Is "x has stopped typing" actually useful?
(In reply to aleth [:aleth] from comment #1)

 
> Would it be enough to move the typing notification to the right hand side?

YES PLEASE!! :)  It would be far more than enough.   I think that would actually resolve the issue for the most part. Conversations are usually short anyway, and in the event the conversation runs that far across to the right side, the context would more easily allow for understanding what is said under the indicator.

 
> Is the real problem that typing notifications, in particular "x has stopped
> typing", stay on the screen for too long?

I think that at least putting it on the right side and maybe making 'x has stopped typing' disappear sooner, would likely help as well
This shows typing notifications on the right. 

Current edge case: Links appear on the left unless there's already a typing notification shown, in which case they appear on the right as they reuse the existing panel.

Should we try this in nightlies for a bit?
Attachment #8597747 - Flags: review?(nhnt11)
Attachment #8597747 - Flags: feedback?(clokep)
(In reply to aleth [:aleth] from comment #3)
> Created attachment 8597747 [details] [diff] [review]
> typingright.diff.diff
> 
> This shows typing notifications on the right. 
> 
> Current edge case: Links appear on the left unless there's already a typing
> notification shown, in which case they appear on the right as they reuse the
> existing panel.
> 
> Should we try this in nightlies for a bit?

Looking forward to see this idea implemented.  Thank you!
Comment on attachment 8597747 [details] [diff] [review]
typingright.diff.diff

Review of attachment 8597747 [details] [diff] [review]:
-----------------------------------------------------------------

The approach looks reasonable, but I didn't try it and I'm not super familiar with that code.
Attachment #8597747 - Flags: feedback?(clokep) → feedback+
nhnt11, can you take a look at this today? Thanks!
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8597747 [details] [diff] [review]
typingright.diff.diff

Review of attachment 8597747 [details] [diff] [review]:
-----------------------------------------------------------------

::: im/content/tabbrowser.xml
@@ +1594,5 @@
>          <body><![CDATA[
>            let container = this.parentNode;
> +          let xor = (a, b) => (a || b) && !(a && b);
> +          let alignRight = xor(getComputedStyle(container).direction == "rtl",
> +                               this.hasAttribute("flipped"));

xor is really just "a != b": http://jonathonhill.net/2009-02-12/logical-xor-in-javascript/
Comment on attachment 8597747 [details] [diff] [review]
typingright.diff.diff

Review of attachment 8597747 [details] [diff] [review]:
-----------------------------------------------------------------

Works well.
I like clokep's suggestion of using a != b, but maybe still keep it in a variable (let xor = (a, b) => a != b) for readability?
Attachment #8597747 - Flags: review?(nhnt11) → review+
url:        https://hg.mozilla.org/comm-central/rev/7ef320f10b21560ab77fd26f37e11f242a7ac65c
changeset:  7ef320f10b21560ab77fd26f37e11f242a7ac65c
user:       aleth <aleth@instantbird.org>
date:       Thu Feb 26 22:35:44 2015 +0100
description:
Bug 1136396 - Typing indicator makes latest message hard to read. r=nhnt11
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
Updating milestone from 1.6 to 42.
Target Milestone: 1.6 → Instantbird 42
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: