WebGL 1.0.3 conformance error: conformance/attribs/gl-bindAttribLocation-aliasing.html

RESOLVED FIXED in Firefox 50

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: Luke, Assigned: Kyle Fung)

Tracking

(Blocks: 1 bug)

39 Branch
mozilla50
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: webgl-conformance gfx-noted)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150224030228

Steps to reproduce:

https://www.khronos.org/registry/webgl/sdk/tests/conformance/attribs/gl-bindAttribLocation-aliasing.html?webglVersion=1


Actual results:

Only 17 of 273 passed


Expected results:

Chrome passes all the tests. Firefox fails the test with both the ANGLE and OpenGL backends.
Component: Untriaged → Canvas: WebGL
Product: Firefox → Core
Blocks: 845345
Whiteboard: webgl-conformance
Whiteboard: webgl-conformance → webgl-conformance gfx-noted
(Reporter)

Updated

3 years ago
Summary: WebGL conformance error: conformance/attribs/gl-bindAttribLocation-aliasing.html → WebGL 1.0.3 conformance error: conformance/attribs/gl-bindAttribLocation-aliasing.html
(Reporter)

Updated

3 years ago
No longer blocks: 845345
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 1

3 years ago
Link in 1.0.4 beta suite:
 - https://www.khronos.org/registry/webgl/sdk/tests/conformance/attribs/gl-bindAttribLocation-aliasing.html?webglVersion=1

Tested to fail on the following configurations:
 - GIADA, MACBOOK_AIR_WIN, MACBOOK_PRO_WIN, NEXUS-10, SURFACE, WINDBOX, HASWELL, HPOMEN

Did not fail on the following configurations:
 - SPARK, MACBOOK_AIR_OSX, MACBOOK_PRO_OSX, MACMINI, MACPRO, NEXUS-4, NEXUS-5

See https://bugzilla.mozilla.org/show_bug.cgi?id=1178601 for hardware configuration details of these systems.
(Assignee)

Updated

2 years ago
Assignee: nobody → kfung
(Assignee)

Comment 2

2 years ago
Created attachment 8645934 [details]
link-test-case.html

Reduced test case. Needs to be run inside the WebGL conformance test suite.
(Assignee)

Comment 3

2 years ago
Created attachment 8646032 [details] [diff] [review]
dup-index-check.patch

Failures coming from allowing linking if there are multiple attributes bound to the same index.

Added a check inside WebGLProgram::LinkProgram() for such duplicates and caused link failure if one is found.
Attachment #8646032 - Flags: review?(jgilbert)
(Assignee)

Comment 4

2 years ago
It looks like fixing Bug 1136411 will fix this problem, but fixing this bug will not fix Bug 1136411.
Depends on: 1136411
(Assignee)

Updated

2 years ago
Attachment #8646032 - Flags: review?(jgilbert)
(Assignee)

Updated

2 years ago
Attachment #8646032 - Attachment is obsolete: true
(Reporter)

Updated

2 years ago
Blocks: 1193526
Blocks: 1246063
No longer blocks: 1193526
(Reporter)

Comment 5

2 years ago
Still failing on Intel HD 4000 under Ubuntu 16.04
50.0a1 (2016-06-25)
(Reporter)

Updated

2 years ago
OS: Windows 7 → Linux
Created attachment 8769024 [details]
Bug 1136410 - Forbid attrib aliasing. - '

Review commit: https://reviewboard.mozilla.org/r/63002/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63002/
Attachment #8769024 - Flags: review?(mtseng)
Duplicate of this bug: 1136411
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce963bab8a40
Try's green.
Comment on attachment 8769024 [details]
Bug 1136410 - Forbid attrib aliasing. - '

https://reviewboard.mozilla.org/r/63002/#review60224
Attachment #8769024 - Flags: review?(mtseng) → review+

Comment 11

a year ago
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd20afbbe00d
Forbid attrib aliasing. - r=mtseng'
https://hg.mozilla.org/integration/mozilla-inbound/rev/a39f9b0037ae
Build fix.

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fd20afbbe00d
https://hg.mozilla.org/mozilla-central/rev/a39f9b0037ae
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Blocks: 1286768
You need to log in before you can comment on or make changes to this bug.