Closed Bug 1136488 Opened 7 years ago Closed 7 years ago

Rename HomePanelDelegate delegate member to avoid conflict with UINavigationController

Categories

(Firefox for iOS :: Firefox Accounts, defect)

Product:
Firefox for iOS
Component:
Firefox Accounts
Platform:
All
iOS 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

IRC r+ from bnicholson and st3fan.  UINavigationController already has a .delegate, so we can't make UINavigationController implement HomePanel.  Easy fix is to rename HomePanel.delegate.
https://github.com/mozilla/firefox-ios/commit/d3518ba9a8e2dc185fd1966e4ad9f272da749447
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.