Closed Bug 1136520 Opened 7 years ago Closed 7 years ago

Stop parenting Xray expando objects to a non-global

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

I don't see an obvious reason for this to be happening; we never seem to get the expando object's parent.
Comment on attachment 8568932 [details] [diff] [review]
Stop parenting Xray expando objects to a non-global

Review of attachment 8568932 [details] [diff] [review]:
-----------------------------------------------------------------

I think this may have been used before we switched xray expandos to a C++ WeakMap, but now it does indeed appear unused. Huzzah!

::: js/xpconnect/wrappers/XrayWrapper.cpp
@@ +941,5 @@
>              JS_ClearPendingException(cx);
>      }
>  #endif
>  
>      // Create the expando object. We parent it directly to the target object.

Comment needs updating.
Attachment #8568932 - Flags: review?(bobbyholley) → review+
Comment updated, good catch.
https://hg.mozilla.org/mozilla-central/rev/0c29786741a7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.